From: Jason Riedy <ejr@EECS.Berkeley.EDU>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Initial AIX portability fixes.
Date: Tue, 06 Dec 2005 16:07:16 -0800 [thread overview]
Message-ID: <21075.1133914036@lotus.CS.Berkeley.EDU> (raw)
In-Reply-To: <Pine.LNX.4.63.0512070055430.5888@wbgn013.biozentrum.uni-wuerzburg.de>
And Johannes Schindelin writes:
- Why not enclose the #define in #ifndef/#endif, and do the real magic in
- the Makefile? Within the AIX clause:
- ALL_CFLAGS += -D_XOPEN_SOURCE=500 -XOPEN_SOURCE_EXTENDED=1
Because other files do _not_ compile when given those options.
I'm going for minimal changes to the existing structure; the
#define for glibc2 has been there a long, long time. Yes, it
probably can be done better, but these are 1.0rc versions...
Jason
next prev parent reply other threads:[~2005-12-07 0:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 22:20 [PATCH] Initial AIX portability fixes Jason Riedy
2005-12-06 23:58 ` Johannes Schindelin
2005-12-07 0:07 ` Jason Riedy [this message]
2005-12-07 0:12 ` Junio C Hamano
2005-12-07 0:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21075.1133914036@lotus.CS.Berkeley.EDU \
--to=ejr@eecs.berkeley.edu \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.