All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: xenomai <xenomai@xenomai.org>
Subject: Re: [PATCH] Alchemy: Fix rt_task_unblock() for RT_MUTEX
Date: Mon, 4 Apr 2022 14:40:14 +0200 (CEST)	[thread overview]
Message-ID: <2108061040.215035.1649076014582.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <1018f867-d9a7-4c0a-a6ee-6b9a5d457c0a@siemens.com>

----- Ursprüngliche Mail -----
> Von: "Jan Kiszka" <jan.kiszka@siemens.com>
>> Uff yes. Just tried building with --with-core=mercury and it failed. ;-\
>> 
>> So, when mercury is enabled, alchemy will use NPTL.
>> This means rt_task_unblock() cannot work on mercury because
>> pthread_mutex_lock() will not return EINTR either.
>> 
>> Fixing the build for mercury should be easy by adding an ifdef
>> CONFIG_XENO_MERCURY.
>> But I'm not sure how to fix unblocking for the mercury case.
> 
> Either by ignoring that case on mercury (it has not predecessor in
> Xenomai 2, and it can't be fixed via posix means) or by redefining the
> behavior for everyone, i.e. by exempting rt_mutex_acquire* from
> rt_task_unblock.

I'd strongly vote for option #1. The application I work an cleans
up deadlocks with rt_task_unblock().
This seems to work quite well on Xenomai 2.

Thanks,
//richard


  reply	other threads:[~2022-04-04 12:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30 20:16 [PATCH] Alchemy: Fix rt_task_unblock() for RT_MUTEX Richard Weinberger
2022-03-31  8:25 ` Bezdeka, Florian
2022-03-31  8:36   ` Richard Weinberger
2022-04-01  7:16     ` Bezdeka, Florian
2022-04-04  9:39       ` Richard Weinberger
2022-04-04 11:20         ` Jan Kiszka
2022-04-04 13:26           ` Richard Weinberger
2022-04-04 11:21 ` Jan Kiszka
2022-04-04 12:17   ` Richard Weinberger
2022-04-04 12:34     ` Jan Kiszka
2022-04-04 12:40       ` Richard Weinberger [this message]
2023-01-09 16:25 ` [PATCH v2] " Aaron Marcher
2023-01-10  5:52   ` Jan Kiszka
2023-01-10  7:54     ` Florian Bezdeka
2023-01-10  8:02       ` Jan Kiszka
2023-01-10  8:05         ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2108061040.215035.1649076014582.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.