From: Thomas Monjalon <thomas@monjalon.net>
To: guohongzhi1@huawei.com
Cc: dev@dpdk.org, stable@dpdk.org, olivier.matz@6wind.com,
mb@smartsharesystems.com, konstantin.ananyev@intel.com,
jiayu.hu@intel.com, ferruh.yigit@intel.com,
nicolas.chautru@intel.com, cristian.dumitrescu@intel.com,
zhoujingbin@huawei.com, chenchanghu@huawei.com,
jerry.lilijun@huawei.com, haifeng.lin@huawei.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] bugfix: rte_raw_checksum
Date: Wed, 24 Jun 2020 14:21:59 +0200 [thread overview]
Message-ID: <2108086.oFbrkSXBjQ@thomas> (raw)
In-Reply-To: <20200527134009.19444-1-guohongzhi1@huawei.com>
27/05/2020 15:40, guohongzhi:
> From: Hongzhi Guo <guohongzhi1@huawei.com>
>
> __rte_raw_cksum should consider Big Endian.
We need to explain the logic in the commit log.
> Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>
> ---
> +#if (RTE_BYTE_ORDER == RTE_BIG_ENDIAN)
> + sum += *((const uint8_t *)u16_buf) << 8;
> +#else
> sum += *((const uint8_t *)u16_buf);
> +#endif
*((const uint8_t *)u16_buf) should be an uint8_t.
What is the expected behaviour of shifting 8 bits of a byte?
next prev parent reply other threads:[~2020-06-24 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 13:40 [dpdk-dev] [PATCH] bugfix: rte_raw_checksum guohongzhi
2020-05-27 14:58 ` Morten Brørup
2020-06-24 12:21 ` Thomas Monjalon [this message]
2020-06-24 13:00 ` [dpdk-dev] [dpdk-stable] " Morten Brørup
2020-06-24 15:04 ` Thomas Monjalon
2020-06-24 15:11 ` Morten Brørup
2020-07-06 7:36 ` Olivier Matz
2020-07-06 7:46 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2108086.oFbrkSXBjQ@thomas \
--to=thomas@monjalon.net \
--cc=chenchanghu@huawei.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=guohongzhi1@huawei.com \
--cc=haifeng.lin@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=jiayu.hu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=nicolas.chautru@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=zhoujingbin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.