Re: [PATCH mptcp-net v2 1/3] mptcp: remove MPTCP 'ifdef' in TCP SYN cookies

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Tue, 6 Dec 2022, Matthieu Baerts wrote:

> Hi Mat,
>
> On 05/12/2022 22:52, Mat Martineau wrote:
>> On Wed, 30 Nov 2022, Matthieu Baerts wrote:
>>
>>> To ease the maintenance, it is often recommended to avoid having #ifdef
>>> preprocessor conditions.
>>>
>>> Here the section related to CONFIG_MPTCP was quite short but the next
>>> commit needs to add more code around. It is then cleaner to move
>>> specific MPTCP code to functions located in net/mptcp directory.
>>>
>>> Now that mptcp_subflow_request_sock_ops structure can be static, it can
>>> also be marked as "read only after init".
>>>
>>> Suggested-by: Paolo Abeni <pabeni@redhat.com>
>>> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
>>
>> Hi Matthieu -
>>
>> I noticed today that there's no Fixes: tag for this commit, which the
>> netdev CI will check for. Like you say in the commit message, this patch
>> is a small bit of refactoring to prepare for the following patch(es) -
>> should it share Fixes: tags with those or just let the git dependencies
>> speak for themselves?
>
> I don't think we need to add a Fixes tag because as you said, it is
> mentioned this modification is needed for the next patch. I'm sure
> netdev maintainers will understand why it doesn't have a "Fixes" tag.
> But I guess we can also add it (even if it is not really a fix).
>
> We should probably Cc 'stable' ML on the 3 patches but we never really
> did before.
>
> Up to you, if you prefer, I can add it :)
>

I think it's ok to try without it, not every patch merged to -net has one.

Regarding cc: to stable, I've been trying to do that for patches we do 
want backported. We don't want that tag included when sending to mptcp-net 
on our ML as git-send-email would spam the stable list, so I've been 
adding them to the .patch files before upstreaming to netdev. Adding the 
Cc: stable tag in the export branch would probably be ok as long as we're 
careful in other cases where the patches are emailed (when not 
upstreaming).

--
Mat Martineau
Intel