From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 1/2] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() Date: Thu, 12 May 2016 16:47:17 +0300 Message-ID: <2110406.8vuOB8d0uX@avalon> References: <1463057606-1916-1-git-send-email-noralf@tronnes.org> <1463057606-1916-2-git-send-email-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 80BFF6E8AA for ; Thu, 12 May 2016 13:47:18 +0000 (UTC) In-Reply-To: <1463057606-1916-2-git-send-email-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?ISO-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgTm9yYWxmLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUaHVyc2RheSAxMiBNYXkg MjAxNiAxNDo1MzoyNSBOb3JhbGYgVHLDuG5uZXMgd3JvdGU6Cj4gQWRkIGRybV9mYl9jbWFfY3Jl YXRlX3dpdGhfZnVuY3MoKSBmb3IgZHJpdmVycyB0aGF0IG5lZWQgdG8gc2V0IHRoZQo+IGRpcnR5 KCkgY2FsbGJhY2suCj4gCj4gQ2M6IGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbQo+ IFNpZ25lZC1vZmYtYnk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+IC0t LQo+IAo+IENoYW5nZXMgc2luY2UgdjE6Cj4gLSBFeHBhbmQgZG9jcwo+IAo+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuYyB8IDMxICsrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0KPiAgaW5jbHVkZS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuaCAgICAgfCAgMyArKysKPiAg MiBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuYwo+IGIvZHJpdmVy cy9ncHUvZHJtL2RybV9mYl9jbWFfaGVscGVyLmMgaW5kZXggMzE2NWFjMC4uZWRlNzdjOSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jCj4gQEAgLTE1OSwxMyArMTU5LDE3IEBA IHN0YXRpYyBzdHJ1Y3QgZHJtX2ZiX2NtYSAqZHJtX2ZiX2NtYV9hbGxvYyhzdHJ1Y3QKPiBkcm1f ZGV2aWNlICpkZXYsIH0KPiAKPiAgLyoqCj4gLSAqIGRybV9mYl9jbWFfY3JlYXRlKCkgLSAoc3Ry dWN0IGRybV9tb2RlX2NvbmZpZ19mdW5jcyAqKS0+ZmJfY3JlYXRlCj4gY2FsbGJhY2sgZnVuY3Rp b24KPiArICogZHJtX2ZiX2NtYV9jcmVhdGVfd2l0aF9mdW5jcygpIC0gaGVscGVyIGZ1bmN0aW9u IGZvciB0aGUKPiArICogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmRybV9tb2Rl X2NvbmZpZ19mdW5jcyAtPmZiX2NyZWF0ZQo+ICsgKiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjYWxsYmFjayBmdW5jdGlvbgo+ICAgKgo+IC0gKiBJZiB5b3VyIGhhcmR3YXJlIGhh cyBzcGVjaWFsIGFsaWdubWVudCBvciBwaXRjaCByZXF1aXJlbWVudHMgdGhlc2UKPiBzaG91bGQg YmUKPiAtICogY2hlY2tlZCBiZWZvcmUgY2FsbGluZyB0aGlzIGZ1bmN0aW9uLgo+ICsgKiBUaGlz IGNhbiBiZSB1c2VkIHRvIHNldCAmZHJtX2ZyYW1lYnVmZmVyX2Z1bmNzIGZvciBkcml2ZXJzIHRo YXQgbmVlZCB0aGUKPiArICogZGlydHkoKSBjYWxsYmFjay4gVXNlIGRybV9mYl9jbWFfY3JlYXRl KCkgaWYgeW91IGRvbid0IG5lZWQgdG8gY2hhbmdlICsKPiAqICZkcm1fZnJhbWVidWZmZXJfZnVu Y3MuCj4gICAqLwo+IC1zdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpkcm1fZmJfY21hX2NyZWF0ZShz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+IC0Jc3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYsIGNv bnN0IHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyICptb2RlX2NtZCkKPiArc3RydWN0IGRybV9mcmFt ZWJ1ZmZlciAqZHJtX2ZiX2NtYV9jcmVhdGVfd2l0aF9mdW5jcyhzdHJ1Y3QgZHJtX2RldmljZQo+ ICpkZXYsCj4gKwlzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwgY29uc3Qgc3RydWN0IGRybV9t b2RlX2ZiX2NtZDIgKm1vZGVfY21kLAo+ICsJc3RydWN0IGRybV9mcmFtZWJ1ZmZlcl9mdW5jcyAq ZnVuY3MpCgpTaG91bGRuJ3QgdGhlIGZ1bmNzIGFyZ3VtZW50IGJlIGNvbnN0ID8KCkFwYXJ0IGZy b20gdGhhdCwKCkFja2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlk ZWFzb25ib2FyZC5jb20+Cgo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2ZiX2NtYSAqZmJfY21hOwo+ICAJ c3RydWN0IGRybV9nZW1fY21hX29iamVjdCAqb2Jqc1s0XTsKPiBAQCAtMjAyLDcgKzIwNiw3IEBA IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmRybV9mYl9jbWFfY3JlYXRlKHN0cnVjdAo+IGRybV9k ZXZpY2UgKmRldiwgb2Jqc1tpXSA9IHRvX2RybV9nZW1fY21hX29iaihvYmopOwo+ICAJfQo+IAo+ IC0JZmJfY21hID0gZHJtX2ZiX2NtYV9hbGxvYyhkZXYsIG1vZGVfY21kLCBvYmpzLCBpLCAmZHJt X2ZiX2NtYV9mdW5jcyk7Cj4gKwlmYl9jbWEgPSBkcm1fZmJfY21hX2FsbG9jKGRldiwgbW9kZV9j bWQsIG9ianMsIGksIGZ1bmNzKTsKPiAgCWlmIChJU19FUlIoZmJfY21hKSkgewo+ICAJCXJldCA9 IFBUUl9FUlIoZmJfY21hKTsKPiAgCQlnb3RvIGVycl9nZW1fb2JqZWN0X3VucmVmZXJlbmNlOwo+ IEBAIC0yMTUsNiArMjE5LDIxIEBAIGVycl9nZW1fb2JqZWN0X3VucmVmZXJlbmNlOgo+ICAJCWRy bV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlX3VubG9ja2VkKCZvYmpzW2ldLT5iYXNlKTsKPiAgCXJl dHVybiBFUlJfUFRSKHJldCk7Cj4gIH0KPiArRVhQT1JUX1NZTUJPTF9HUEwoZHJtX2ZiX2NtYV9j cmVhdGVfd2l0aF9mdW5jcyk7Cj4gKwo+ICsvKioKPiArICogZHJtX2ZiX2NtYV9jcmVhdGUoKSAt ICZkcm1fbW9kZV9jb25maWdfZnVuY3MgLT5mYl9jcmVhdGUgY2FsbGJhY2sKPiBmdW5jdGlvbgo+ ICsgKgo+ICsgKiBJZiB5b3VyIGhhcmR3YXJlIGhhcyBzcGVjaWFsIGFsaWdubWVudCBvciBwaXRj aCByZXF1aXJlbWVudHMgdGhlc2UKPiBzaG91bGQgYmUKPiArICogY2hlY2tlZCBiZWZvcmUgY2Fs bGluZyB0aGlzIGZ1bmN0aW9uLiBVc2UgZHJtX2ZiX2NtYV9jcmVhdGVfd2l0aF9mdW5jcygpCj4g aWYKPiArICogeW91IG5lZWQgdG8gc2V0ICZkcm1fZnJhbWVidWZmZXJfZnVuY3MgLT5kaXJ0eS4K PiArICovCj4gK3N0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmRybV9mYl9jbWFfY3JlYXRlKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsCj4gKwlzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwgY29uc3Qg c3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGVfY21kKQo+ICt7Cj4gKwlyZXR1cm4gZHJtX2Zi X2NtYV9jcmVhdGVfd2l0aF9mdW5jcyhkZXYsIGZpbGVfcHJpdiwgbW9kZV9jbWQsCj4gKwkJCQkJ ICAgICZkcm1fZmJfY21hX2Z1bmNzKTsKPiArfQo+ICBFWFBPUlRfU1lNQk9MX0dQTChkcm1fZmJf Y21hX2NyZWF0ZSk7Cj4gCj4gIC8qKgo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZmJf Y21hX2hlbHBlci5oCj4gYi9pbmNsdWRlL2RybS9kcm1fZmJfY21hX2hlbHBlci5oIGluZGV4IGM2 ZDljOWMuLjFmOWE4YmMgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2ZiX2NtYV9oZWxw ZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9mYl9jbWFfaGVscGVyLmgKPiBAQCAtMzEsNiAr MzEsOSBAQCB2b2lkIGRybV9mYl9jbWFfZGVzdHJveShzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpm Yik7Cj4gIGludCBkcm1fZmJfY21hX2NyZWF0ZV9oYW5kbGUoc3RydWN0IGRybV9mcmFtZWJ1ZmZl ciAqZmIsCj4gIAlzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwgdW5zaWduZWQgaW50ICpoYW5k bGUpOwo+IAo+ICtzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpkcm1fZmJfY21hX2NyZWF0ZV93aXRo X2Z1bmNzKHN0cnVjdCBkcm1fZGV2aWNlCj4gKmRldiwKPiArCXN0cnVjdCBkcm1fZmlsZSAqZmls ZV9wcml2LCBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqbW9kZV9jbWQsCj4gKwlzdHJ1 Y3QgZHJtX2ZyYW1lYnVmZmVyX2Z1bmNzICpmdW5jcyk7Cj4gIHN0cnVjdCBkcm1fZnJhbWVidWZm ZXIgKmRybV9mYl9jbWFfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlzdHJ1Y3Qg ZHJtX2ZpbGUgKmZpbGVfcHJpdiwgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGVf Y21kKTsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752711AbcELNrU (ORCPT ); Thu, 12 May 2016 09:47:20 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:50328 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbcELNrT convert rfc822-to-8bit (ORCPT ); Thu, 12 May 2016 09:47:19 -0400 From: Laurent Pinchart To: Noralf =?ISO-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, daniel@ffwll.ch, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() Date: Thu, 12 May 2016 16:47:17 +0300 Message-ID: <2110406.8vuOB8d0uX@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.16; x86_64; ; ) In-Reply-To: <1463057606-1916-2-git-send-email-noralf@tronnes.org> References: <1463057606-1916-1-git-send-email-noralf@tronnes.org> <1463057606-1916-2-git-send-email-noralf@tronnes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Noralf, Thank you for the patch. On Thursday 12 May 2016 14:53:25 Noralf Trønnes wrote: > Add drm_fb_cma_create_with_funcs() for drivers that need to set the > dirty() callback. > > Cc: laurent.pinchart@ideasonboard.com > Signed-off-by: Noralf Trønnes > --- > > Changes since v1: > - Expand docs > > drivers/gpu/drm/drm_fb_cma_helper.c | 31 +++++++++++++++++++++++++------ > include/drm/drm_fb_cma_helper.h | 3 +++ > 2 files changed, 28 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c > b/drivers/gpu/drm/drm_fb_cma_helper.c index 3165ac0..ede77c9 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -159,13 +159,17 @@ static struct drm_fb_cma *drm_fb_cma_alloc(struct > drm_device *dev, } > > /** > - * drm_fb_cma_create() - (struct drm_mode_config_funcs *)->fb_create > callback function > + * drm_fb_cma_create_with_funcs() - helper function for the > + * &drm_mode_config_funcs ->fb_create > + * callback function > * > - * If your hardware has special alignment or pitch requirements these > should be > - * checked before calling this function. > + * This can be used to set &drm_framebuffer_funcs for drivers that need the > + * dirty() callback. Use drm_fb_cma_create() if you don't need to change + > * &drm_framebuffer_funcs. > */ > -struct drm_framebuffer *drm_fb_cma_create(struct drm_device *dev, > - struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd) > +struct drm_framebuffer *drm_fb_cma_create_with_funcs(struct drm_device > *dev, > + struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd, > + struct drm_framebuffer_funcs *funcs) Shouldn't the funcs argument be const ? Apart from that, Acked-by: Laurent Pinchart > { > struct drm_fb_cma *fb_cma; > struct drm_gem_cma_object *objs[4]; > @@ -202,7 +206,7 @@ struct drm_framebuffer *drm_fb_cma_create(struct > drm_device *dev, objs[i] = to_drm_gem_cma_obj(obj); > } > > - fb_cma = drm_fb_cma_alloc(dev, mode_cmd, objs, i, &drm_fb_cma_funcs); > + fb_cma = drm_fb_cma_alloc(dev, mode_cmd, objs, i, funcs); > if (IS_ERR(fb_cma)) { > ret = PTR_ERR(fb_cma); > goto err_gem_object_unreference; > @@ -215,6 +219,21 @@ err_gem_object_unreference: > drm_gem_object_unreference_unlocked(&objs[i]->base); > return ERR_PTR(ret); > } > +EXPORT_SYMBOL_GPL(drm_fb_cma_create_with_funcs); > + > +/** > + * drm_fb_cma_create() - &drm_mode_config_funcs ->fb_create callback > function > + * > + * If your hardware has special alignment or pitch requirements these > should be > + * checked before calling this function. Use drm_fb_cma_create_with_funcs() > if > + * you need to set &drm_framebuffer_funcs ->dirty. > + */ > +struct drm_framebuffer *drm_fb_cma_create(struct drm_device *dev, > + struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd) > +{ > + return drm_fb_cma_create_with_funcs(dev, file_priv, mode_cmd, > + &drm_fb_cma_funcs); > +} > EXPORT_SYMBOL_GPL(drm_fb_cma_create); > > /** > diff --git a/include/drm/drm_fb_cma_helper.h > b/include/drm/drm_fb_cma_helper.h index c6d9c9c..1f9a8bc 100644 > --- a/include/drm/drm_fb_cma_helper.h > +++ b/include/drm/drm_fb_cma_helper.h > @@ -31,6 +31,9 @@ void drm_fb_cma_destroy(struct drm_framebuffer *fb); > int drm_fb_cma_create_handle(struct drm_framebuffer *fb, > struct drm_file *file_priv, unsigned int *handle); > > +struct drm_framebuffer *drm_fb_cma_create_with_funcs(struct drm_device > *dev, > + struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd, > + struct drm_framebuffer_funcs *funcs); > struct drm_framebuffer *drm_fb_cma_create(struct drm_device *dev, > struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd); -- Regards, Laurent Pinchart