From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: ab/only-single-progress-at-once (was: What's cooking in git.git (Oct 2021, #07; Fri, 29))
Date: Mon, 01 Nov 2021 20:27:25 +0100 [thread overview]
Message-ID: <211101.86wnlr3c98.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqr1c3e57a.fsf@gitster.g>
On Fri, Oct 29 2021, Junio C Hamano wrote:
> * ab/only-single-progress-at-once (2021-10-27) 8 commits
> - progress.c: add & assert a "global_progress" variable
> - various *.c: use isatty(1|2), not isatty(STDIN_FILENO|STDERR_FILENO)
> - pack-bitmap-write.c: don't return without stop_progress()
> - progress.c: add temporary variable from progress struct
> - progress.c tests: test some invalid usage
> - progress.c tests: make start/stop commands on stdin
> - progress.c test helper: add missing braces
> - leak tests: fix a memory leaks in "test-progress" helper
>
> Further tweaks on progress API.
>
> Correction of the course may be required?
> cf. <211025.8635opi8om.gmgdl@evledraar.gmail.com>
> cf. <cover-v4-0.8-00000000000-20211025T111915Z-avarab@gmail.com>
Re-rolled a v5 to address that discussion:
https://lore.kernel.org/git/cover-v5-0.8-00000000000-20211101T190630Z-avarab@gmail.com/
Per the re-roll the discussion doesn't directly affect this series, it
was on a part of the commit message that's musing about some WIP/POC
code I wrote, and which might use the new interface added in 8/8 in the
future.
In any case, I updated the commit message to note the potential issues
with that WIP code that were raised.
But as far as this progressing (aside from the rc period & all that) I
don't see why it should be blocked on that.
next prev parent reply other threads:[~2021-11-01 19:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 0:17 What's cooking in git.git (Oct 2021, #07; Fri, 29) Junio C Hamano
2021-11-01 19:26 ` ab/config-based-hooks-2 (was: What's cooking in git.git (Oct 2021, #07; Fri, 29)) Ævar Arnfjörð Bjarmason
2021-11-01 20:17 ` ab/config-based-hooks-2 Junio C Hamano
2021-11-01 19:27 ` Ævar Arnfjörð Bjarmason [this message]
2021-11-01 19:30 ` tb/plug-pack-bitmap-leaks (was: What's cooking in git.git (Oct 2021, #07; Fri, 29)) Ævar Arnfjörð Bjarmason
2021-11-01 19:32 ` tp/send-email-completion " Ævar Arnfjörð Bjarmason
2021-11-01 19:34 ` js/scalar " Ævar Arnfjörð Bjarmason
2021-11-01 19:39 ` ms/customizable-ident-expansion " Ævar Arnfjörð Bjarmason
2021-11-01 20:23 ` ms/customizable-ident-expansion Junio C Hamano
[not found] ` <CABFYoQA82u8Um6L439_bU4a+WpkdXOcbU8foPjqnVw+4MnNU0A@mail.gmail.com>
2021-11-08 19:14 ` ms/customizable-ident-expansion Ævar Arnfjörð Bjarmason
2021-11-08 20:01 ` ms/customizable-ident-expansion Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211101.86wnlr3c98.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.