All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>, Jeff King <peff@peff.net>,
	git@vger.kernel.org
Subject: Re: move some test-tools to 'unstable plumbing' built-ins
Date: Mon, 08 Nov 2021 21:19:10 +0100	[thread overview]
Message-ID: <211108.86zgqee6rm.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq7ddiv4oi.fsf@gitster.g>


On Mon, Nov 08 2021, Junio C Hamano wrote:

> Taylor Blau <me@ttaylorr.com> writes:
>
>> In my experience I *rarely* rely on test-helpers when debugging wedged
>> repositories, and much more often end up either in gdb, or in an
>> anonymized copy of the repository on a different server. I would imagine
>> that others have similar experiences.
>>
>> So unless we had a much more compelling reason to have the test helpers
>> more readily available, I do not think that the risk our users will
>> begin to depend on these unstable tools is worth taking.
>
> OK.  It sounds like a sensible argument against such a change.

It's an argument against not flipping "make installing them be optional"
flag on by default, but we could otherwise move some of t/helper to
builtin/, which would help by encouraging us to write at least
boilerplate docs for them.

Git developers & similar parties could then set them to be installed for
ad-hoc debugging.

Whatever anyone things on that, just on Taylor's "begin to depend on"...

I really don't buy the argument that there's no amount of warnings in
our documentation that we can include which would give us future license
to willy-nilly change certain things.

If that is being argued then that seems to categorically exclude certain
other things, e.g. including "scalar" in-tree at all, because if we
can't trust users to read the warnings about it being "contrib-y"...

  reply	other threads:[~2021-11-08 20:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05  9:01 [PATCH] test_bitmap_hashes(): handle repository without bitmaps Jeff King
2021-11-05 18:52 ` Junio C Hamano
2021-11-05 19:11   ` Taylor Blau
2021-11-05 23:29     ` Jeff King
2021-11-06  4:08     ` move some test-tools to 'unstable plumbing' built-ins (was: [PATCH] test_bitmap_hashes(): handle repository without bitmaps) Ævar Arnfjörð Bjarmason
2021-11-07 17:06       ` Taylor Blau
2021-11-08 19:16         ` move some test-tools to 'unstable plumbing' built-ins Junio C Hamano
2021-11-08 20:19           ` Ævar Arnfjörð Bjarmason [this message]
2021-11-08 22:06             ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=211108.86zgqee6rm.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.