Re: [PATCH v5 1/3] ethdev: add IPv6 routing extension header definition

[Thomas Monjalon <thomas@monjalon.net>]

01/02/2023 12:35, Rongwei Liu:
> +/**
> + * IPv6 Routing Extension Header
> + */
> +struct rte_ipv6_routing_ext {
> +	uint8_t next_hdr;			/**< Protocol, next header. */
> +	uint8_t hdr_len;			/**< Header length. */
> +	uint8_t type;				/**< Extension header type. */
> +	uint8_t segments_left;			/**< Valid segments number. */
> +	__extension__
> +	union {
> +		rte_be32_t flags;		/**< Packet control data per type. */
> +		struct {
> +			uint8_t last_entry;	/**< The last_entry field of SRH */
> +			uint8_t flag;		/**< Packet flag. */
> +			rte_be16_t tag;		/**< Packet tag. */
> +		};
> +	};
> +	/** Following variable number of segments. */

Don't use doxygen here as there is no field following.

Wording suggestion:
"Next are 128-bit IPv6 address fields to describe segments."

> +} __rte_packed;