All of lore.kernel.org
 help / color / mirror / Atom feed
From: ANISH KUMAR <anish.singh@samsung.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: "liam.girdwood@wolfsonmicro.com" <liam.girdwood@wolfsonmicro.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"broonie@opensource.wolfsonmicro.com"
	<broonie@opensource.wolfsonmicro.com>
Subject: Re: No shutdown code in soc-core.c
Date: Sat, 17 Apr 2010 07:02:43 +0000 (GMT)	[thread overview]
Message-ID: <21125077.117201271487763642.JavaMail.weblogic@epml11> (raw)

Why this shutdown filed is not there in the struct shown below:
static struct platform_driver soc_driver 
{
.shutdown       = soc_shutdown,                  //soc-core.c 
}
This shutdown call this codec_dev->shutdown function 
In my case i am turning off the amplifier using this call.Which
solved my problem of "TAK" sound during reset.

I agree that soc_codec_close() is calling the shutdown function
but in my case there is a call to set the path after this which is
turning on the amplifier and suddenly if we reset the phone it is
causing "TAK" sound.Probably because AMPLIFIER was on.

Anyway why this function call soc_shutdown() is there in 
soc-core.c if no one is calling it???
I know there will be a redundancy if we have shutdown field
in the struct shown above as soc_codec_close call also calls
codec shutdown code.
But in my case it is solving my problem. 

             reply	other threads:[~2010-04-17  7:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-17  7:02 ANISH KUMAR [this message]
2010-04-19 12:15 ` No shutdown code in soc-core.c Liam Girdwood
  -- strict thread matches above, loose matches on Subject: below --
2010-04-22  8:10 ANISH KUMAR
2010-04-19 13:19 ANISH KUMAR
2010-04-19 14:10 ` Liam Girdwood
2010-04-19 16:59   ` Mark Brown
2010-04-16 16:44 ANISH KUMAR
2010-04-16 17:21 ` Liam Girdwood
2010-04-16  2:29 ANISH KUMAR
2010-04-16 16:03 ` Liam Girdwood
2010-04-16 18:47 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21125077.117201271487763642.JavaMail.weblogic@epml11 \
    --to=anish.singh@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=liam.girdwood@wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.