Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Liviu Dudau <liviu.dudau@arm.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	dri-devel@lists.freedesktop.org,
	Thierry Reding <thierry.reding@gmail.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Thomas Hellstrom <thellstrom@vmware.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Alexey Brodkin <abrodkin@synopsys.com>,
	Xinliang Liu <z.liuxinliang@hisilicon.com>,
	Xinwei Kong <kong.kongxinwei@hisilicon.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Mali DP Maintainers <malidp@foss.arm.com>,
	Dave Airlie <airlied@redhat.com>,
	Chen Feng <puck.chen@hisilicon.com>, Jyri Sarha <jsarha@ti.com>,
	Vincent Abriou <vincent.abriou@st.com>,
	VMware Graphics <linux-graphics-maintainer@vmware.com>,
	Alison Wang <alison.wang@freescale.com>,
	S eung-Woo Kim <sw0312.kim@samsung.com>,
	Philippe Cornu <philippe.cornu@st.com>
Subject: Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function
Date: Wed, 28 Jun 2017 16:44:28 +0300	[thread overview]
Message-ID: <2113599.L3AQ0Itlz5@avalon> (raw)
In-Reply-To: <20170628134149.GA1103@e110455-lin.cambridge.arm.com>

Hi Liviu,

On Wednesday 28 Jun 2017 14:41:49 Liviu Dudau wrote:
> On Wed, Jun 28, 2017 at 12:16:20AM +0300, Laurent Pinchart wrote:
> > The old state is useful for drivers that need to perform operations at
> > enable time that depend on the transition between the old and new
> > states.
> > 
> > While at it, rename the operation to .atomic_enable() to be consistent
> > with .atomic_disable(), as the .enable() operation is used by atomic
> > helpers only.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  drivers/gpu/drm/arc/arcpgu_crtc.c               |  5 ++--
> >  drivers/gpu/drm/arm/hdlcd_crtc.c                |  5 ++--
> >  drivers/gpu/drm/arm/malidp_crtc.c               |  5 ++--
> 
> For the hdlcd and mali-dp changes:
> 
> Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
> 
> I'll assume you are going to push the changes through drm-misc rather
> than me cherry picking the changes from the patch.

Yes I will, you don't need to worry about this patch :-)

> >  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c  |  5 ++--
> >  drivers/gpu/drm/drm_atomic_helper.c             |  7 +++--
> >  drivers/gpu/drm/drm_simple_kms_helper.c         |  5 ++--
> >  drivers/gpu/drm/exynos/exynos_drm_crtc.c        |  5 ++--
> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c      |  5 ++--
> >  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c  |  5 ++--
> >  drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c |  5 ++--
> >  drivers/gpu/drm/imx/ipuv3-crtc.c                |  5 ++--
> >  drivers/gpu/drm/mediatek/mtk_drm_crtc.c         |  5 ++--
> >  drivers/gpu/drm/meson/meson_crtc.c              |  5 ++--
> >  drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c        |  5 ++--
> >  drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c        |  5 ++--
> >  drivers/gpu/drm/omapdrm/omap_crtc.c             |  5 ++--
> >  drivers/gpu/drm/qxl/qxl_display.c               |  5 ++--
> >  drivers/gpu/drm/rcar-du/rcar_du_crtc.c          |  5 ++--
> >  drivers/gpu/drm/rockchip/rockchip_drm_vop.c     |  5 ++--
> >  drivers/gpu/drm/sti/sti_crtc.c                  |  5 ++--
> >  drivers/gpu/drm/stm/ltdc.c                      |  5 ++--
> >  drivers/gpu/drm/sun4i/sun4i_crtc.c              |  5 ++--
> >  drivers/gpu/drm/tegra/dc.c                      |  5 ++--
> >  drivers/gpu/drm/tilcdc/tilcdc_crtc.c            |  8 +++++-
> >  drivers/gpu/drm/vc4/vc4_crtc.c                  |  5 ++--
> >  drivers/gpu/drm/virtio/virtgpu_display.c        |  5 ++--
> >  drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c             |  7 +++--
> >  drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c            |  7 +++--
> >  drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c            |  5 ++--
> >  drivers/gpu/drm/zte/zx_vou.c                    |  5 ++--
> >  include/drm/drm_modeset_helper_vtables.h        | 38 +++++++++----------
> >  31 files changed, 117 insertions(+), 80 deletions(-)

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel