From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2414C433DB for ; Sun, 31 Jan 2021 23:08:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8160164E36 for ; Sun, 31 Jan 2021 23:08:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230092AbhAaXIV (ORCPT ); Sun, 31 Jan 2021 18:08:21 -0500 Received: from mail.z3ntu.xyz ([128.199.32.197]:33444 "EHLO mail.z3ntu.xyz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229852AbhAaXHD (ORCPT ); Sun, 31 Jan 2021 18:07:03 -0500 Received: by mail.z3ntu.xyz (Postfix, from userid 182) id 30B2AC1BE0; Sun, 31 Jan 2021 23:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1612134370; bh=ZcNE+YqUbFE7ilb2fMS+PExd3K0uSxm8CKC9+sqOxqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uvMrcujV8rQrnfI7s6nm6b1D/zJcUE6lUEd4Hm4DBgu0JxZ/QSZjbP8oorF9lT3mP FYeFwv0F/V7KV5jtmuNl+sho9k0k3mos/7sUCz0vs2oZchxUw/OVE8wrejHinKh/Iz 3o8ZqCW+9/hhOn3stJY0pHiHSn5UCx46n2F5wHoY= Received: from g550jk.localnet (80-110-106-213.cgn.dynamic.surfer.at [80.110.106.213]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 29673C1BDD; Sun, 31 Jan 2021 23:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1612134362; bh=ZcNE+YqUbFE7ilb2fMS+PExd3K0uSxm8CKC9+sqOxqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=P+jxQO2i9OTmHF2los3Da52AJ1CD+bg6SSnGdH4SsZ7unxE0cYr9VPx01GTKErHab aByOXK/nI9vwnyZ+Hqquf6uc3rFWN9KRL1aAdve6ef7FfzchB+GsRuZX0QT6yVTTGS YmiozrIwJnxsZ/30GSXRkXNPAajuYnuJqEATRi6o= From: Luca Weiss To: Rob Clark , ~postmarketos/upstreaming@lists.sr.ht Cc: ~postmarketos/upstreaming@lists.sr.ht, Iskren Chernev , Sean Paul , David Airlie , Daniel Vetter , Thomas Zimmermann , Maxime Ripard , Abhinav Kumar , Emil Velikov , Christophe JAILLET , Lee Jones , Brian Masney , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Iskren Chernev Subject: Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels Date: Mon, 01 Feb 2021 00:06:01 +0100 Message-ID: <2117852.HdQyuLfLX8@g550jk> In-Reply-To: <20210127152442.533468-1-iskren.chernev@gmail.com> References: <20210127152442.533468-1-iskren.chernev@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Iskren, On Mittwoch, 27. J=E4nner 2021 16:24:40 CET Iskren Chernev wrote: > Before the offending commit in msm_atomic_commit_tail wait_flush was > called once per frame, after the commit was submitted. After it > wait_flush is also called at the beginning to ensure previous > potentially async commits are done. >=20 > For cmd panels the source of wait_flush is a ping-pong irq notifying > a completion. The completion needs to be notified with complete_all so > multiple waiting parties (new async committers) can proceed. >=20 > Signed-off-by: Iskren Chernev > Suggested-by: Rob Clark > Fixes: 2d99ced787e3d ("drm/msm: async commit support") > --- I've tested this now on fairphone-fp2 and lge-nexus5-hammerhead, works grea= t! Tested-by: Luca Weiss Regards Luca From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B22C433E0 for ; Mon, 1 Feb 2021 08:11:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA8DB64E24 for ; Mon, 1 Feb 2021 08:11:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA8DB64E24 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=z3ntu.xyz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C1D56E43D; Mon, 1 Feb 2021 08:11:07 +0000 (UTC) X-Greylist: delayed 534 seconds by postgrey-1.36 at gabe; Sun, 31 Jan 2021 23:15:04 UTC Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id 467E86E134; Sun, 31 Jan 2021 23:15:04 +0000 (UTC) Received: by mail.z3ntu.xyz (Postfix, from userid 182) id 6E05EC1BE5; Sun, 31 Jan 2021 23:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1612134368; bh=ZcNE+YqUbFE7ilb2fMS+PExd3K0uSxm8CKC9+sqOxqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nqigVK+ACcfP6sHau6sKVzu/t3JOyrt4Mt6eSSF478B6kaM4hbdGj0cO6fjIEvoCt dwVDvVxwJYxnu4sE59NQeUdFCNmhtqw/Psw/Yi6CDpLjUJX0GGZiIsSbKfM0wWO29R dosaZpjq+JyC2QbEJHjJPOLSa2hZdN78rGBkfArw= Received: from g550jk.localnet (80-110-106-213.cgn.dynamic.surfer.at [80.110.106.213]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 29673C1BDD; Sun, 31 Jan 2021 23:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1612134362; bh=ZcNE+YqUbFE7ilb2fMS+PExd3K0uSxm8CKC9+sqOxqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=P+jxQO2i9OTmHF2los3Da52AJ1CD+bg6SSnGdH4SsZ7unxE0cYr9VPx01GTKErHab aByOXK/nI9vwnyZ+Hqquf6uc3rFWN9KRL1aAdve6ef7FfzchB+GsRuZX0QT6yVTTGS YmiozrIwJnxsZ/30GSXRkXNPAajuYnuJqEATRi6o= From: Luca Weiss To: Rob Clark , ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels Date: Mon, 01 Feb 2021 00:06:01 +0100 Message-ID: <2117852.HdQyuLfLX8@g550jk> In-Reply-To: <20210127152442.533468-1-iskren.chernev@gmail.com> References: <20210127152442.533468-1-iskren.chernev@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 01 Feb 2021 08:11:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Thomas Zimmermann , David Airlie , Lee Jones , dri-devel@lists.freedesktop.org, Brian Masney , Abhinav Kumar , linux-kernel@vger.kernel.org, Iskren Chernev , ~postmarketos/upstreaming@lists.sr.ht, linux-arm-msm@vger.kernel.org, Christophe JAILLET , Emil Velikov , Sean Paul , Maxime Ripard Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Iskren, On Mittwoch, 27. J=E4nner 2021 16:24:40 CET Iskren Chernev wrote: > Before the offending commit in msm_atomic_commit_tail wait_flush was > called once per frame, after the commit was submitted. After it > wait_flush is also called at the beginning to ensure previous > potentially async commits are done. > = > For cmd panels the source of wait_flush is a ping-pong irq notifying > a completion. The completion needs to be notified with complete_all so > multiple waiting parties (new async committers) can proceed. > = > Signed-off-by: Iskren Chernev > Suggested-by: Rob Clark > Fixes: 2d99ced787e3d ("drm/msm: async commit support") > --- I've tested this now on fairphone-fp2 and lge-nexus5-hammerhead, works grea= t! Tested-by: Luca Weiss Regards Luca _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel