Re: [PATCH v2 0/6] Btrfs: free space tree and sanity test fixes

[Chandan Rajendra <chandan@linux.vnet.ibm.com>]

On Thursday, September 22, 2016 05:22:31 PM Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> This is v2 of my earlier series "Btrfs: fix free space tree
> bitmaps+tests on big-endian systems" [1]. Patches 1, 4, and 5 are the
> same as patches 1, 2, and 3 from the original series. I've added patch 2
> to fix another bug I noticed (an xfstest went out earlier). Patch 3 is
> the result of the earlier discussion here [2]. Finally, patch 6 was
> necessary to get the sanity tests to run on my MIPS emulator.
> 
> This series applies to v4.8-rc7. The sanity tests pass on both x86-64
> and MIPS, and there are no xfstests regressions. Chandan and Anatoly,
> could you test these out as well?

Hello Omar,

I have executed xfstests on a big endian ppc64 guest with 'MOUNT_OPTIONS="-o
space_cache=v2"' config option. I have also executed generic/127 on a
filesystem created using "fragment-free-space-tree.py" that you had provided
sometime ago. I did not notice any regressions during the test runs.

Tested-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>

> 
> I'm working on the btrfs-progs follow up, but these patches are safe
> without that -- the new FREE_SPACE_TREE_VALID bit will stop all versions
> of btrfs-progs from mounting read-write.
> 
> Thanks!
> 
> 1: http://marc.info/?l=linux-btrfs&m=146853909905570&w=2
> 2: http://marc.info/?l=linux-btrfs&m=147448992301110&w=2
> 
> Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> Cc: Anatoly Pugachev <matorola@gmail.com>
> 
> Omar Sandoval (6):
>   Btrfs: fix free space tree bitmaps on big-endian systems
>   Btrfs: fix mount -o clear_cache,space_cache=v2
>   Btrfs: catch invalid free space trees
>   Btrfs: fix extent buffer bitmap tests on big-endian systems
>   Btrfs: expand free space tree sanity tests to catch endianness bug
>   Btrfs: use less memory for delalloc sanity tests
> 
>  fs/btrfs/ctree.h                       |   3 +-
>  fs/btrfs/disk-io.c                     |  33 ++++---
>  fs/btrfs/extent_io.c                   |  64 +++++++++----
>  fs/btrfs/extent_io.h                   |  22 +++++
>  fs/btrfs/free-space-tree.c             |  19 ++--
>  fs/btrfs/tests/extent-io-tests.c       |  95 +++++++++++--------
>  fs/btrfs/tests/free-space-tree-tests.c | 164 +++++++++++++++++++--------------
>  include/uapi/linux/btrfs.h             |  10 +-
>  8 files changed, 261 insertions(+), 149 deletions(-)
> 
> 

-- 
chandan