From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Wodkowski,
PawelX"
<pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] ethdev: fix missing parenthesis
Date: Fri, 16 Jan 2015 18:04:12 +0100 [thread overview]
Message-ID: <2120377.FvxLenVaOl@xps13> (raw)
In-Reply-To: <F6F2A6264E145F47A18AB6DF8E87425D12B88371-kPTMFJFq+rFP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-16 09:40, Wodkowski, PawelX:
> > Good catch!
> > Was introduced in commit 4bdefaade6d1 (VMDQ enhancements).
> > Note that quite often, when a patch contains too much things,
> > we miss this kind of bugs. That's a reason to well split patches.
>
> What is most surprising I did not spotted this, neither the compiler
> what I think it should. It was my IDE which pointed possible bug.
>
> Are we using '-Wparentheses' switch? If not, we should consider
> to use this switch?
It's already included in -Wall which is set in WERROR_FLAGS.
--
Thomas
prev parent reply other threads:[~2015-01-16 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 15:05 [PATCH] ethdev: fix missing parenthesis Michal Jastrzebski
[not found] ` <1420815925-7988-1-git-send-email-michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-15 13:16 ` Thomas Monjalon
2015-01-16 9:40 ` Wodkowski, PawelX
[not found] ` <F6F2A6264E145F47A18AB6DF8E87425D12B88371-kPTMFJFq+rFP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-16 17:04 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2120377.FvxLenVaOl@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.