From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v8 02/19] eal: enable multi process init
	callback
Date: Tue, 03 Jul 2018 23:51:05 +0200
Message-ID: <2121919.otauVgk3WW@xps>
References: <20180607123849.14439-1-qi.z.zhang@intel.com>
 <3358274.MJj7BZBBQ7@xps>
 <039ED4275CED7440929022BC67E7061153243598@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "Shelton, Benjamin H" <benjamin.h.shelton@intel.com>, "Vangati,
 Narender" <narender.vangati@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4FD6F1BE1E
 for <dev@dpdk.org>; Tue,  3 Jul 2018 23:51:11 +0200 (CEST)
In-Reply-To: <039ED4275CED7440929022BC67E7061153243598@SHSMSX103.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/07/2018 17:16, Zhang, Qi Z:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 
> > Hi Qi,
> > 
> > Sorry I do not understand neither the commit log, nor the doxygen.
> > If it can help, consider your reader is in a bad mood and needs a pleasant
> > description.
> 
> OK, I think is not a grammar issue since it almost passed a grammar check :)
> 
> So more explanation: 
> Basically we need to register mp action callback in ethdev layer,

What is "mp action callback"?
Why do you need it in ethdev?

> but this should happens during rte_eal_init 

Why it should be done in rte_eal_init?

> ethdev don't have a general init function that can be invoked by eal
> during rte_eal_init, actually I guess, all no-eal module don't have 

What is "no-eal module"?

> in vdev bus, it register the mp action at the first bus scan happen.
> but in ethdev, we can't do that way, because, we don' t know
> when device will be attached or detached. 
> so we need that function to help register a callback function which will be invoked during rte_eal_init.
> 
> 
> > 
> > 02/07/2018 07:44, Qi Zhang:
> > > Introduce new API rte_eal_register_mp_init that help to register a
> > > callback function which will be invoked right after multi-process
> > > channel be established (rte_mp_channel_init). Typically the API will
> > > be used by other module that want it's mp channel action callbacks can
> > > be registered during rte_eal_init automatically.
> > [...]
> > > +/**
> > > + * @warning
> > > + * @b EXPERIMENTAL: this API may change without prior notice
> > > + *
> > > + * Register a callback function that will be invoked right after
> > > + * multi-process channel be established (rte_mp_channel_init).
> > > +Typically
> > > + * the function is used by other module that want it's mp channel
> > > + * action callbacks can be registered during rte_eal_init automatically.
> > > + *
> > > + * @note
> > > + *   This function only take effect when be called before rte_eal_init,
> > > + *   and all registered callback will be clear during rte_eal_cleanup.