From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:38236 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920AbdF1TB4 (ORCPT ); Wed, 28 Jun 2017 15:01:56 -0400 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Laurent Pinchart , DRI Development , Linux-Renesas , Kieran Bingham Subject: Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker Date: Wed, 28 Jun 2017 22:01:48 +0300 Message-ID: <2122582.afWRqxtlHg@avalon> In-Reply-To: References: <20170628185055.16379-1-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Geert, On Wednesday 28 Jun 2017 20:52:53 Geert Uytterhoeven wrote: > On Wed, Jun 28, 2017 at 8:50 PM, Laurent Pinchart wrote: > > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > > start to CRTC resume") changed the order of the plane commit and CRTC > > enable operations to accommodate the runtime PM requirements. However, > > this introduced corruption in the first displayed frame, as the CRTC is > > now enabled without any plane configured. On Gen2 hardware the first > > frame will be black and likely unnoticed, but on Gen3 hardware we end up > > starting the display before the VSP compositor, which is more > > noticeable. > > > > To fix this, revert the order of the commit operations back, and handle > > runtime PM requirements in the CRTC .atomic_begin() and .atomic_enable() > > helper operation handlers. > > > > Signed-off-by: Laurent Pinchart > > > > Fixes: ... I thought about that, but this patch fixes a problem caused by a combination of commits. The one mentioned above is probably the easiest to point at, but the problem only became, well, problematic, with the introduction of Gen3 support in v4.6. Furthermore, while it's probably possible to backport this patch to v4.6, I don't think it needs to be included in -stable. For all those reasons, a Fixes tag might not be useful. Of course please feel free to disagree :-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker Date: Wed, 28 Jun 2017 22:01:48 +0300 Message-ID: <2122582.afWRqxtlHg@avalon> References: <20170628185055.16379-1-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id DCF206E5A3 for ; Wed, 28 Jun 2017 19:01:45 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: Linux-Renesas , Laurent Pinchart , Kieran Bingham , DRI Development List-Id: dri-devel@lists.freedesktop.org SGkgR2VlcnQsCgpPbiBXZWRuZXNkYXkgMjggSnVuIDIwMTcgMjA6NTI6NTMgR2VlcnQgVXl0dGVy aG9ldmVuIHdyb3RlOgo+IE9uIFdlZCwgSnVuIDI4LCAyMDE3IGF0IDg6NTAgUE0sIExhdXJlbnQg UGluY2hhcnQgd3JvdGU6Cj4gPiBDb21taXQgNTIwNTViYWZhMWZmICgiZHJtOiByY2FyLWR1OiBN b3ZlIHBsYW5lIGNvbW1pdCBjb2RlIGZyb20gQ1JUQwo+ID4gc3RhcnQgdG8gQ1JUQyByZXN1bWUi KSBjaGFuZ2VkIHRoZSBvcmRlciBvZiB0aGUgcGxhbmUgY29tbWl0IGFuZCBDUlRDCj4gPiBlbmFi bGUgb3BlcmF0aW9ucyB0byBhY2NvbW1vZGF0ZSB0aGUgcnVudGltZSBQTSByZXF1aXJlbWVudHMu IEhvd2V2ZXIsCj4gPiB0aGlzIGludHJvZHVjZWQgY29ycnVwdGlvbiBpbiB0aGUgZmlyc3QgZGlz cGxheWVkIGZyYW1lLCBhcyB0aGUgQ1JUQyBpcwo+ID4gbm93IGVuYWJsZWQgd2l0aG91dCBhbnkg cGxhbmUgY29uZmlndXJlZC4gT24gR2VuMiBoYXJkd2FyZSB0aGUgZmlyc3QKPiA+IGZyYW1lIHdp bGwgYmUgYmxhY2sgYW5kIGxpa2VseSB1bm5vdGljZWQsIGJ1dCBvbiBHZW4zIGhhcmR3YXJlIHdl IGVuZCB1cAo+ID4gc3RhcnRpbmcgdGhlIGRpc3BsYXkgYmVmb3JlIHRoZSBWU1AgY29tcG9zaXRv ciwgd2hpY2ggaXMgbW9yZQo+ID4gbm90aWNlYWJsZS4KPiA+IAo+ID4gVG8gZml4IHRoaXMsIHJl dmVydCB0aGUgb3JkZXIgb2YgdGhlIGNvbW1pdCBvcGVyYXRpb25zIGJhY2ssIGFuZCBoYW5kbGUK PiA+IHJ1bnRpbWUgUE0gcmVxdWlyZW1lbnRzIGluIHRoZSBDUlRDIC5hdG9taWNfYmVnaW4oKSBh bmQgLmF0b21pY19lbmFibGUoKQo+ID4gaGVscGVyIG9wZXJhdGlvbiBoYW5kbGVycy4KPiA+IAo+ ID4gU2lnbmVkLW9mZi1ieTogTGF1cmVudCBQaW5jaGFydAo+ID4gPGxhdXJlbnQucGluY2hhcnQr cmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgo+IAo+IEZpeGVzOiAuLi4KCkkgdGhvdWdodCBhYm91 dCB0aGF0LCBidXQgdGhpcyBwYXRjaCBmaXhlcyBhIHByb2JsZW0gY2F1c2VkIGJ5IGEgY29tYmlu YXRpb24gCm9mIGNvbW1pdHMuIFRoZSBvbmUgbWVudGlvbmVkIGFib3ZlIGlzIHByb2JhYmx5IHRo ZSBlYXNpZXN0IHRvIHBvaW50IGF0LCBidXQgCnRoZSBwcm9ibGVtIG9ubHkgYmVjYW1lLCB3ZWxs LCBwcm9ibGVtYXRpYywgd2l0aCB0aGUgaW50cm9kdWN0aW9uIG9mIEdlbjMgCnN1cHBvcnQgaW4g djQuNi4KCkZ1cnRoZXJtb3JlLCB3aGlsZSBpdCdzIHByb2JhYmx5IHBvc3NpYmxlIHRvIGJhY2tw b3J0IHRoaXMgcGF0Y2ggdG8gdjQuNiwgSSAKZG9uJ3QgdGhpbmsgaXQgbmVlZHMgdG8gYmUgaW5j bHVkZWQgaW4gLXN0YWJsZS4gRm9yIGFsbCB0aG9zZSByZWFzb25zLCBhIEZpeGVzIAp0YWcgbWln aHQgbm90IGJlIHVzZWZ1bC4gT2YgY291cnNlIHBsZWFzZSBmZWVsIGZyZWUgdG8gZGlzYWdyZWUg Oi0pCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=