From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] i40e: Fix a vlan bug
Date: Thu, 04 Dec 2014 11:38:54 +0100
Message-ID: <2122900.sczHU7BWUg@xps13>
References: <1417686605-6778-1-git-send-email-jing.d.chen@intel.com>
 <4822681.F5vea3YAsE@xps13>
 <4341B239C0EFF9468EE453F9E9F4604D0162B2C6@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Chen, Jing D" <jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D0162B2C6-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-12-04 10:30, Chen, Jing D:
> As I don't know what commit he is based on, I'd like to generate a new patch with latest dpdk repo.

There's something wrong here. You rework a patch and you don't know
what was the current status but you expect that the reviewers can understand
it better than you?
You are breaking all the elementary rules of patch management.
We have currently 2 fixes pending for the same bug. 

PS: please don't top post.

-- 
Thomas

> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > Sent: Thursday, December 04, 2014 6:26 PM
> > To: Chen, Jing D
> > Cc: dev-VfR2kkLFssw@public.gmane.org; Qiu, Michael
> > Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
> > 
> > 2014-12-04 10:18, Qiu, Michael:
> > > Hi Mark,
> > >
> > > I think Huawei (huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org) has one patch set to fix this issue.
> > >
> > > If your patch is totally different with him:
> > >
> > > [dpdk-dev] [PATCH v4 0/2] lib/librte_pmd_i40e: set vlan filter fix
> > >
> > > please ignore my comments :)
> > >
> > > But you both calculation are different.
> > 
> > Yes, please Jing (Mark), if you reworked the v4 patch, it would clearer
> > to have a changelog, to name it v5 and to insert it in the previous
> > thread with --in-reply-to.
> > At the moment, both patches block each other.
> > 
> > --
> > Thomas