From: David Howells <dhowells@redhat.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org,
selinux@tycho.nsa.gov, serge.hallyn@canonical.com,
eparis@redhat.com
Subject: Re: [PATCH 8/9] LSM: Pass linux_binprm pointer to open_exec() so creds are available
Date: Thu, 28 Apr 2011 16:27:12 +0100 [thread overview]
Message-ID: <21236.1304004432@redhat.com> (raw)
In-Reply-To: <201104220225.p3M2PjJR020777@www262.sakura.ne.jp>
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote:
> 819 struct linux_binprm bprm;
>
> Here bprm is allocated from stack memory without initialization
> whereas bprm in do_execve() is allocated using kzalloc().
That's true; most of it doesn't need initialisation, but some bits of it do -
but aren't initialised here. Not only that, it's quite a large struct, so
probably shouldn't be on the stack anyway - especially in NOMMU mode.
Anyway, I've posted a patch independent of this patch series to fix this.
David
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2011-04-28 15:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 14:30 [PATCH 0/9] Open loaders and interpreters with new creds during exec David Howells
2011-04-21 14:30 ` [PATCH 1/9] TOMOYO: Fix tomoyo_dentry_open() to use the right creds David Howells
2011-04-21 14:30 ` [PATCH 2/9] TOMOYO: Derive the new domain for an exec'd process in tomoyo_bprm_set_creds() David Howells
2011-04-21 14:30 ` [PATCH 3/9] LSM: Permit commit_creds() to take a const pointer David Howells
2011-04-21 14:30 ` [PATCH 4/9] LSM: Make the linux_binfmt creds pointer const and pass creds to bprm_set_creds David Howells
2011-04-21 14:30 ` [PATCH 5/9] LSM: Install the new credentials earlier in the exec procedure David Howells
2011-04-21 14:31 ` [PATCH 6/9] LSM: Pass linux_binprm pointer to kernel_read() so creds are available David Howells
2011-04-21 14:31 ` [PATCH 7/9] LSM: Allow an LSM to indicate that it wants bprm->file reopening with new creds David Howells
2011-04-21 14:31 ` [PATCH 8/9] LSM: Pass linux_binprm pointer to open_exec() so creds are available David Howells
[not found] ` <201104220225.p3M2PjJR020777@www262.sakura.ne.jp>
2011-04-28 15:27 ` David Howells [this message]
2011-04-21 14:31 ` [PATCH 9/9] LSM: Use derived creds for accessing an executable's interpreter and binary loader David Howells
2011-04-21 16:12 ` [PATCH 0/9] Open loaders and interpreters with new creds during exec Stephen Smalley
2011-04-21 16:30 ` Daniel J Walsh
2011-04-21 17:32 ` Casey Schaufler
2011-04-21 18:13 ` David Howells
2011-04-21 18:53 ` David Howells
[not found] ` <20110428200218.GB9186@hallyn.com>
2011-04-30 10:48 ` David Howells
2011-05-02 13:28 ` Stephen Smalley
2011-05-04 12:12 ` David Howells
2011-05-04 13:15 ` David Howells
[not found] ` <20110504144558.GC917@mail.hallyn.com>
2011-05-04 16:27 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21236.1304004432@redhat.com \
--to=dhowells@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=selinux@tycho.nsa.gov \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.