From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v1 1/1] examples/l2fwd-crypto: improve random
	key generator
Date: Tue, 07 Jun 2016 22:30:31 +0200
Message-ID: <21237364.CLn9ZV8ln9@xps13>
References: <1464183292-24280-1-git-send-email-piotrx.t.azarewicz@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, declan.doherty@intel.com
To: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 78029AD96
 for <dev@dpdk.org>; Tue,  7 Jun 2016 22:30:33 +0200 (CEST)
Received: by mail-wm0-f48.google.com with SMTP id v199so35643979wmv.0
 for <dev@dpdk.org>; Tue, 07 Jun 2016 13:30:33 -0700 (PDT)
In-Reply-To: <1464183292-24280-1-git-send-email-piotrx.t.azarewicz@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-25 15:34, Piotr Azarewicz:
> This patch improve generate_random_key() function by replacing rand()
> function with reading from /dev/urandom.
> 
> CID 120136 : Calling risky function (DC.WEAK_CRYPTO)
> dont_call: rand should not be used for security related applications, as
> linear congruential algorithms are too easy to break
> 
> Coverity issue: 120136
> 
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> ---
>  examples/l2fwd-crypto/main.c |   18 +++++++++++++-----

Is it relevant for this example?