Re: [PATCH] Input: gpio_keys: allocate pins

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Friday, October 12, 2012 11:26:00 PM Linus Walleij wrote:
> On Fri, Oct 12, 2012 at 5:55 PM, Daniel Mack <zonque@gmail.com> wrote:
> > This allows DT driven boards to allocate and configure the pinmux once
> > the driver is probed.
> > 
> > Signed-off-by: Daniel Mack <zonque@gmail.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> (...)
> 
> > +       /* request pin mux */
> > +       pinctrl = devm_pinctrl_get_select_default(dev);
> > +       if (IS_ERR(pinctrl))
> > +               dev_warn(dev, "pins are not configured from the
> > driver\n");
> 
> I think dev_warn() is rather nasty to throw in here, dev_info() is OK.
> 
> However I suspect this driver could actually handle default, idle and sleep
> states, especially after the runtime PM patches discussed elsewhere,
> but that can be patched later.

I take this as Acked-by then?

-- 
Dmitry