From: David Woodhouse <dwmw2@infradead.org>
To: "Bjorn Eriksson" <mdeans@algonet.se>
Cc: mtd@infradead.org
Subject: Re: Three change suggestions to nand.c and friends.
Date: Fri, 13 Oct 2000 16:35:35 +0100 [thread overview]
Message-ID: <21265.971451335@redhat.com> (raw)
In-Reply-To: <000b01c03529$edc4c1c0$0800a8c0@win95.inteloop.se>
mdeans@algonet.se said:
> 1) Right now the code needs the moddi3() helper to perform it's
> checks. I suggest adding the requirement that {.oobblock} must be a
> power of two.
That's sensible, but best just to require it. Don't piss about with config
options.
> 2) I've also rewritten nand.c changing all 'NAND_CTRL |= this->CLE;'
> -> NAND_SET_CMD et.al. Different hardware different support code.
Check with sjhill but that sounds reasonable.
> 3) I moved nand_flash_ids[] to a new file, nand_ids.h since nand.h is
> included in several different places and not all .c-files that
> #include it needs nand_flash_ids[] (thus creating dups).
OK.
--
dwmw2
To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org
prev parent reply other threads:[~2000-10-13 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-13 15:26 Three change suggestions to nand.c and friends Bjorn Eriksson
2000-10-13 15:35 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21265.971451335@redhat.com \
--to=dwmw2@infradead.org \
--cc=mdeans@algonet.se \
--cc=mtd@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.