From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: yocto@yoctoproject.org
Subject: Re: [layerindex-web][PATCH 4/4] update.py: check whether branch existed when nocheckout
Date: Mon, 09 Jul 2018 10:34:07 +0200 [thread overview]
Message-ID: <21268191.2cf1WCTquc@localhost.localdomain> (raw)
In-Reply-To: <8be7c6c9057c9b1d461aacfde8459adeddb348d5.1531109397.git.liezhi.yang@windriver.com>
Hi Robert,
On Monday, 9 July 2018 6:11:30 AM CEST Robert Yang wrote:
> Fixed:
> Assume there is no master branch in hello layer:
> $ update.py -l hello -b master
> INFO: Skipping update of layer hello - branch master doesn't exist
>
> This is correct since hello layer doesn't have master branch, but when --nocheckout:
> $ update.py -l hello -b master --nocheckout
> [snip]
> INFO: Sorting layers for branch mater:
> WARNING: Cannot find required collections on branch master:
> WARNING: hello: LAYERDEPENDS: <snip>
>
> This is incorrect, this patch fixed the problem, now it skips it since the
> branch doesn't exists when --nocheckout.
This fix doesn't seem right. The intention of --nocheckout is to not check anything
out, i.e. use whatever HEAD is in the current repository. It wouldn't be correct
to get the commit from the origin in this case.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2018-07-09 8:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 4:11 [layerindex-web][PATCH 0/4] update.py: several fixes Robert Yang
2018-07-09 4:11 ` [layerindex-web][PATCH 1/4] update_layer.py: avoid calling setup_core_layer_sys_path() when --initial Robert Yang
2018-07-09 4:11 ` [layerindex-web][PATCH 2/4] utils.py: fix checkout_repo when no HEAD Robert Yang
2018-07-09 4:11 ` [layerindex-web][PATCH 3/4] update.py: add layers when RECOMMENDS isn't satisfied Robert Yang
2018-07-09 4:11 ` [layerindex-web][PATCH 4/4] update.py: check whether branch existed when nocheckout Robert Yang
2018-07-09 8:34 ` Paul Eggleton [this message]
2018-07-09 8:36 ` Paul Eggleton
2018-07-09 8:45 ` Robert Yang
2018-07-09 9:40 ` Paul Eggleton
2018-07-09 8:42 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21268191.2cf1WCTquc@localhost.localdomain \
--to=paul.eggleton@linux.intel.com \
--cc=liezhi.yang@windriver.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.