From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@meshcoding.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: don't access unregistered net_device object
Date: Sat, 08 Aug 2015 00:48:11 +0800 [thread overview]
Message-ID: <2129549.sqPbc6jJBU@voltaire> (raw)
In-Reply-To: <1438719979-15778-1-git-send-email-antonio@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Tuesday, August 04, 2015 22:26:19 Antonio Quartulli wrote:
> In batadv_hardif_disable_interface() there is a call to
> batadv_softif_destroy_sysfs() which in turns invokes
> unregister_netdevice() on the soft_iface.
> After this point we cannot rely on the soft_iface object
> anymore because it might get free'd by the netdev periodic
> routine at any time.
>
> For this reason the netdev_upper_dev_unlink(.., soft_iface) call
> is moved before the invocation of batadv_softif_destroy_sysfs() so
> that we can be sure that the soft_iface object is still valid.
>
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---
> net/batman-adv/hard-interface.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied in revision 958aafbb.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-08-07 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 20:26 [B.A.T.M.A.N.] [PATCH maint] batman-adv: don't access unregistered net_device object Antonio Quartulli
2015-08-07 16:48 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2129549.sqPbc6jJBU@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.