All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] smartmontools: import from OE classic
Date: Fri, 03 May 2013 15:48:22 +0100	[thread overview]
Message-ID: <2129589.jKF1vi4yO8@helios> (raw)
In-Reply-To: <0EBE068C-2C2D-468C-BEB1-85FB799B94D6@dominion.thruhere.net>

On Friday 03 May 2013 16:40:13 Koen Kooi wrote:
> Op 3 mei 2013, om 16:35 heeft Paul Eggleton <paul.eggleton@linux.intel.com>
> het volgende geschreven:
> > IMO, let's keep the separate inc file, but drop PR and INC_PR.
> 
> I still haven't heard a compelling case why smartmontools needs a .inc and
> all the other recipes in meta-oe don't. So drop the inc and be consistent
> with other recipes.

All the other recipes? You mean all of them except for the significant number 
you can find if you run "git grep require.*inc" in meta-oe?

On Friday 03 May 2013 16:39:13 Koen Kooi wrote:
> It's unnecessary clutter and in the smartmontools case unneeded as well.

How is it any less necessary for smartmontools than any other recipe?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2013-05-03 15:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 20:39 [meta-oe][PATCH] smartmontools: import from OE classic Nicolas Dechesne
2013-04-26 21:41 ` Koen Kooi
2013-04-27  8:24   ` Paul Eggleton
2013-04-27 10:34     ` Philip Balister
2013-04-27 11:13       ` Paul Eggleton
2013-04-29  6:40         ` Nicolas Dechesne
2013-05-03 14:00           ` Nicolas Dechesne
2013-05-03 14:35             ` Paul Eggleton
2013-05-03 14:40               ` Koen Kooi
2013-05-03 14:48                 ` Paul Eggleton [this message]
2013-05-03 14:10         ` Koen Kooi
2013-05-03 14:30           ` Paul Eggleton
2013-05-03 14:39             ` Koen Kooi
2013-05-03 14:30           ` Nicolas Dechesne
2013-05-03 14:42             ` Paul Eggleton
2013-05-03 15:09               ` Martin Jansa
2013-05-03 15:15                 ` Philip Balister
2013-05-06  8:19                   ` Nicolas Dechesne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2129589.jKF1vi4yO8@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.