From: Evgeniy Polyakov <zbr@ioremap.net>
To: Michal Nazarewicz <mina86@mina86.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: w1: make w1_slave::flags long to avoid casts
Date: Fri, 01 Nov 2013 20:01:39 +0400 [thread overview]
Message-ID: <212981383321699@web5m.yandex.ru> (raw)
In-Reply-To: <xa1teh71iz3a.fsf@mina86.com>
Hi everyone
31.10.2013, 13:12, "Michal Nazarewicz" <mina86@mina86.com>:
>>> int ttl;
>> ... w1_slave.ttl?
For noisy lines this was a 'timeout' after which system considered attached
device as failed, the noisier line is the longer is timeout
I experimented with meters-long w1 wires and it required several
search fails to correctly determine that device disappeared
> Now that I look at documentation, I think you are correct, but the
> problem is on big-endian 64-bit architectures. The fix is still
> valid, but the commit message not so much. Something along the
> lines of the following would be better:
Guys, you so much overcomplicate things - this field is basically a set of in-memory flags
for attached device, there is no need to even think about how it is present in different endianess
Or do I miss something fundamental there? I wrote it gazillions years ago and probably already forgot something
next prev parent reply other threads:[~2013-11-01 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 11:56 [PATCH] drivers: w1: make w1_slave::flags long to avoid casts Michal Nazarewicz
2013-10-30 22:59 ` Andrew Morton
2013-10-31 9:11 ` Michal Nazarewicz
2013-11-01 16:01 ` Evgeniy Polyakov [this message]
2013-11-01 19:30 ` Andrew Morton
2013-11-02 4:10 ` Рустафа Джамурахметов
2013-11-02 16:58 ` Michal Nazarewicz
2013-11-02 17:19 ` Рустафа Джамурахметов
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=212981383321699@web5m.yandex.ru \
--to=zbr@ioremap.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.