From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] drm/rockchip: vop: fix window origin calculation Date: Tue, 10 Nov 2015 15:57:34 +0100 Message-ID: <2130118.giXtpUm1Fo@phil> References: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Yao Cc: Russell King , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org QW0gRGllbnN0YWcsIDEwLiBOb3ZlbWJlciAyMDE1LCAxNzo1OToxMCBzY2hyaWViIE1hcmsgWWFv Ogo+IEZyb206IERvbWluaWsgQmVociA8ZGJlaHJAY2hyb21pdW0ub3JnPgo+IAo+IFZPUF9XSU54 X0RTUF9TVCBkb2VzIG5vdCByZXF1aXJlIHN1YnRyYWN0aW5nIDEgZnJvbSB0aGUgdmFsdWVzIHdy aXR0ZW4gdG8KPiBpdC4gSXQgYWN0dWFsbHkgY2F1c2VzIHRoZSBzY3JlZW4gdG8gYmUgc2hpZnRl ZCBieSBvbmUgcGl4ZWwuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFyayBZYW8gPG1hcmsueWFvQHJv Y2stY2hpcHMuY29tPgoKT25lIHRoaW5nIEkgbm90aWNlZCwgdGhlIG9yaWdpbmFsIHBhdGNoIFsw XSBoYWQgYSBTaWduZWQtb2ZmIGZyb20KRG9taW5payBhbHJlYWR5IGFuZCB5b3Ugc2hvdWxkIGtl ZXAgdGhhdCBhcyBoZSBpcyB0aGUgYXV0aG9yLCBhbmQgdGhlbgphZGQgeW91ciBTaWduZWQtb2Zm IGJlbG93IHRoYXQsIGFzIHlvdSBhcmUgdGhlIHN1Ym1pdHRlciwKClNvIGl0IHdvdWxkIGxvb2sg bGlrZToKClNpZ25lZC1vZmYtYnk6IERvbWluaWsgQmVociA8ZGJlaHJAY2hyb21pdW0ub3JnPgpT aWduZWQtb2ZmLWJ5OiBNYXJrIFlhbyA8bWFyay55YW9Acm9jay1jaGlwcy5jb20+CgoKVGhhdCBt YXkgbm90IG5lZWQgYSByZXBvc3QsIGJ1dCBzaG91bGQgcHJvYmFibHkgYmUgY29ycmVjdGVkIHdo ZW4gYXBwbHlpbmcKdGhlIHBhdGNoLgoKSGVpa28KClswXSBodHRwczovL2Nocm9taXVtLXJldmll dy5nb29nbGVzb3VyY2UuY29tLyMvYy8yMzMyNTEvCgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYyB8ICAgIDQgKystLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jIGIvZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+IGluZGV4IDQ4NzE5ZGYuLjQ3MzBhZTQgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPiBAQCAt OTU5LDggKzk1OSw4IEBAIHN0YXRpYyBpbnQgdm9wX3VwZGF0ZV9wbGFuZV9ldmVudChzdHJ1Y3Qg ZHJtX3BsYW5lICpwbGFuZSwKPiAgCXZhbCA9IChkZXN0LnkyIC0gZGVzdC55MSAtIDEpIDw8IDE2 Owo+ICAJdmFsIHw9IChkZXN0LngyIC0gZGVzdC54MSAtIDEpICYgMHhmZmZmOwo+ICAJVk9QX1dJ Tl9TRVQodm9wLCB3aW4sIGRzcF9pbmZvLCB2YWwpOwo+IC0JdmFsID0gKGRzcF9zdHkgLSAxKSA8 PCAxNjsKPiAtCXZhbCB8PSAoZHNwX3N0eCAtIDEpICYgMHhmZmZmOwo+ICsJdmFsID0gZHNwX3N0 eSA8PCAxNjsKPiArCXZhbCB8PSBkc3Bfc3R4ICYgMHhmZmZmOwo+ICAJVk9QX1dJTl9TRVQodm9w LCB3aW4sIGRzcF9zdCwgdmFsKTsKPiAgCVZPUF9XSU5fU0VUKHZvcCwgd2luLCByYl9zd2FwLCBy Yl9zd2FwKTsKPiAgCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Tue, 10 Nov 2015 15:57:34 +0100 Subject: [PATCH] drm/rockchip: vop: fix window origin calculation In-Reply-To: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> References: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> Message-ID: <2130118.giXtpUm1Fo@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: > From: Dominik Behr > > VOP_WINx_DSP_ST does not require subtracting 1 from the values written to > it. It actually causes the screen to be shifted by one pixel. > > Signed-off-by: Mark Yao One thing I noticed, the original patch [0] had a Signed-off from Dominik already and you should keep that as he is the author, and then add your Signed-off below that, as you are the submitter, So it would look like: Signed-off-by: Dominik Behr Signed-off-by: Mark Yao That may not need a repost, but should probably be corrected when applying the patch. Heiko [0] https://chromium-review.googlesource.com/#/c/233251/ > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 48719df..4730ae4 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -959,8 +959,8 @@ static int vop_update_plane_event(struct drm_plane *plane, > val = (dest.y2 - dest.y1 - 1) << 16; > val |= (dest.x2 - dest.x1 - 1) & 0xffff; > VOP_WIN_SET(vop, win, dsp_info, val); > - val = (dsp_sty - 1) << 16; > - val |= (dsp_stx - 1) & 0xffff; > + val = dsp_sty << 16; > + val |= dsp_stx & 0xffff; > VOP_WIN_SET(vop, win, dsp_st, val); > VOP_WIN_SET(vop, win, rb_swap, rb_swap); > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753610AbbKJO54 (ORCPT ); Tue, 10 Nov 2015 09:57:56 -0500 Received: from gloria.sntech.de ([95.129.55.99]:38790 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbbKJO5z (ORCPT ); Tue, 10 Nov 2015 09:57:55 -0500 From: Heiko Stuebner To: Mark Yao Cc: David Airlie , Russell King , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Dominik Behr Subject: Re: [PATCH] drm/rockchip: vop: fix window origin calculation Date: Tue, 10 Nov 2015 15:57:34 +0100 Message-ID: <2130118.giXtpUm1Fo@phil> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; ) In-Reply-To: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> References: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: > From: Dominik Behr > > VOP_WINx_DSP_ST does not require subtracting 1 from the values written to > it. It actually causes the screen to be shifted by one pixel. > > Signed-off-by: Mark Yao One thing I noticed, the original patch [0] had a Signed-off from Dominik already and you should keep that as he is the author, and then add your Signed-off below that, as you are the submitter, So it would look like: Signed-off-by: Dominik Behr Signed-off-by: Mark Yao That may not need a repost, but should probably be corrected when applying the patch. Heiko [0] https://chromium-review.googlesource.com/#/c/233251/ > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 48719df..4730ae4 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -959,8 +959,8 @@ static int vop_update_plane_event(struct drm_plane *plane, > val = (dest.y2 - dest.y1 - 1) << 16; > val |= (dest.x2 - dest.x1 - 1) & 0xffff; > VOP_WIN_SET(vop, win, dsp_info, val); > - val = (dsp_sty - 1) << 16; > - val |= (dsp_stx - 1) & 0xffff; > + val = dsp_sty << 16; > + val |= dsp_stx & 0xffff; > VOP_WIN_SET(vop, win, dsp_st, val); > VOP_WIN_SET(vop, win, rb_swap, rb_swap); > >