From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0908C4345F for ; Thu, 2 May 2024 00:50:10 +0000 (UTC) Subject: Re: [PATCH] python3-manifest: prune python3-core To: openembedded-core@lists.openembedded.org From: =?UTF-8?B?R3XDsG5pIE3DoXIgR2lsYmVydA==?= X-Originating-Location: Kopavogur, Capital Region, IS (81.15.100.92) X-Originating-Platform: Windows Chrome 124 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 01 May 2024 17:50:01 -0700 References: In-Reply-To: Message-ID: <2135.1714611001880482361@lists.openembedded.org> Content-Type: multipart/alternative; boundary="48JrIjI2BYG3wq91kApj" List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 02 May 2024 00:50:10 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/198897 --48JrIjI2BYG3wq91kApj Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, May 1, 2024 at 11:27 PM, Tim Orling wrote: >=20 > This manifest is automatically generated by: > https://git.yoctoproject.org/poky/tree/meta/recipes-devtools/python/pytho= n3/create_manifest3.py >=20 >=20 > We do not want to be making manual changes to the json file. If there are > mistakes due to changes in what is now shipped with Python 3.12.x, we > should be fixing in the tooling, not this file. >=20 Using the script was my first approach, but I found out that the script doe= sn't prune the core package and is essentially expecting that the core is a= lready set up correctly in the manifest file. Only items are appended to th= e core, items are never removed as far as I could see. This could certainly be improved and I made an attempt but could not finish= it today. I'd be happy to look into it when I find time. >=20 > Also, please share your local QA tooling. It does no one any good to have > that be siloed >=20 What I have so far is to insert the warning in this line: https://github.co= m/openembedded/openembedded-core/blob/914128f6bd988cde278e087fb9457a0c70c7e= 5ec/meta/lib/oe/package.py#L1343 and adding the following two lines: msg =3D f "FILES variable for package { pkg } contains ' { file } ' but was= not found. \n " oe.qa.handle_error( "files-not-found" , msg , d ) before the 'continue' statement. I also added "files-not-found" to WARN_QA in insane.class just like how "fi= les-invalid" is handled --48JrIjI2BYG3wq91kApj Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, May 1, 2024 at 11:27 PM, Tim Orling wrote:
This manifest is automatically generated by:
 
We do not want to be making manual changes to the json file. If there = are mistakes due to changes in what is now shipped with Python 3.12.x, we s= hould be fixing in the tooling, not this file.
Using the script was my first approach, but I found out that the script doe= sn't prune the core package and is essentially expecting that the core is a= lready set up correctly in the manifest file. Only items are appended to th= e core, items are never removed as far as I could see.

This coul= d certainly be improved and I made an attempt but could not finish it today= . I'd be happy to look into it when I find time.
 
Also, please share your local QA tooling. It does no one any good to h= ave that be siloed
What I have so far is to insert the warning in this line: https://github.com/openembedded/openembedded-core/blob/914128f6bd= 988cde278e087fb9457a0c70c7e5ec/meta/lib/oe/package.py#L1343 and adding = the following two lines:

msg =3D f"FILES variable for package {pkg<= /span>} contains '{file= }' but was not found.\n"
oe.qa.handle_error("files-not-found", msg, d)
before the 'continue' statement.

I also added "files-not-found" to WARN_QA in insane.class just like h= ow "files-invalid" is handled
--48JrIjI2BYG3wq91kApj--