Re: UML fails to build on arch i386

[Richard Weinberger <richard@sigma-star.at>]

Am Donnerstag, 14. Juni 2018, 17:44:37 CEST schrieb Ritesh Raj Sarraf:
> On Thu, 2018-06-14 at 13:15 +0200, Richard Weinberger wrote:
> > > This log missed the main error line:
> > > 
> > >    CC      arch/um/kernel/maccess.o
> > >    CC      arch/um/kernel/kmsg_dump.o
> > >    CC      arch/um/kernel/skas/clone.o
> > > In file included from ./arch/x86/um/shared/sysdep/ptrace.h:42:0,
> > >                   from ./arch/um/include/shared/as-layout.h:38,
> > >                   from arch/um/kernel/skas/clone.c:11:
> > > ./arch/x86/um/shared/sysdep/ptrace_32.h:16:23: error: expected
> > > identifier before numeric constant
> > >   #define PTRACE_SYSEMU 31
> > 
> > Hmm, can you please check how PTRACE_SYSEMU is defined in your UAPI?
> > 
> > The code is pretty boring:
> > #ifndef PTRACE_SYSEMU
> > #define PTRACE_SYSEMU 31
> > #endif
> > 
> > My best guess is that PTRACE_SYSEMU is not a define but something
> > else and then
> > #define fails in an interesting way.
> 
> There's nothing much in here either.
> From file: i386-linux-gnu/sys/ptrace.h
> And it is the same code on x86_64 too, where I've been able to
> successfully build it.
> 
> 
> 
> #ifdef __x86_64__
>   /* Access TLS data.  */
>   PTRACE_ARCH_PRCTL = 30,
> # define PT_ARCH_PRCTL PTRACE_ARCH_PRCTL
> #endif
> 
>   /* Continue and stop at the next syscall, it will not be executed.  */
>   PTRACE_SYSEMU = 31,
> #define PT_SYSEMU PTRACE_SYSEMU

Okay, PTRACE_SYSEMU seems to be part of an enum, that's why UML's #ifndef does not
not protect the #define.

What libc is this?

I think we can remove UML's define check and just assume that every system has PTRACE_SYSEMU
properly defined.

Thanks,
//richard

-- 
sigma star gmbh - Eduard-Bodem-Gasse 6 - 6020 Innsbruck - Austria
ATU66964118 - FN 374287y

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um