From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 3/3] ARM: dts: rockchip: add veyron-minnie board Date: Thu, 03 Dec 2015 15:00:33 +0100 Message-ID: <2137537.DBrTyHZKX9@diego> References: <2767415.mEkgRbSSUB@diego> <3359424.qNn8gsFXpA@diego> <566020EC.7060606@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <566020EC.7060606-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Caesar Wang Cc: Alexandru M Stan , shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Brian Norris , dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Chris Zhong , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org SGkgQ2Flc2FyLCBTaGF3biwKCkFtIERvbm5lcnN0YWcsIDMuIERlemVtYmVyIDIwMTUsIDE5OjAx OjAwIHNjaHJpZWIgQ2Flc2FyIFdhbmc6Cj4g5ZyoIDIwMTXlubQxMuaciDAz5pelIDE4OjQ0LCBI ZWlrbyBTdMO8Ym5lciDlhpnpgZM6Cj4gPiBBbSBEb25uZXJzdGFnLCAzLiBEZXplbWJlciAyMDE1 LCAxODoyNzoyNyBzY2hyaWViIENhZXNhciBXYW5nOgo+ID4+IC4uLi4uYnV0LAo+ID4+IHJlYm9v dCBsb25nIGxvbmcgdGVzdCwgdGhhdCdzIHNlZW0gbW1jIHR1bmUgaGFzIGEgaXNzdWUuCj4gPj4g Cj4gPj4gICAgIDIuNjMwODkyXSBtbWNibGswOiBlcnJvciAtODQgdHJhbnNmZXJyaW5nIGRhdGEs IHNlY3RvciAwLCBuciA4LCBjbWQKPiA+PiAKPiA+PiByZXNwb25zZSAweDkwMCwgY2FyZCBzdGF0 dXMgMHgwCj4gPj4gWyAgICAyLjYzMTAwNl0gbW1jYmxrMDogZXJyb3IgLTExMCBzZW5kaW5nIHN0 YXR1cyBjb21tYW5kLCByZXRyeWluZwo+ID4+IFsgICAgMi42MzEwMThdIG1tY2JsazA6IGVycm9y IC04NCB0cmFuc2ZlcnJpbmcgZGF0YSwgc2VjdG9yIDEsIG5yIDcsIGNtZAo+ID4+IHJlc3BvbnNl IDB4OTAwLCBjYXJkIHN0YXR1cyAweDAKPiA+PiBbICAgIDIuNjMxNzAzXSAgbW1jYmxrMDogdW5h YmxlIHRvIHJlYWQgcGFydGl0aW9uIHRhYmxlCj4gPj4gLi4uCj4gPiAKPiA+IENvdWxkIHlvdSB0 cnkgaWYgd2hhdCB3ZSBkbyBvbiBNaW5uaWUgZml4ZXMgdGhhdCBlcnJvciAoZGlzYWJsaW5nIHR1 bmluZwo+ID4gZm9yIG5vdykgLSBpLmUuIGFkZGluZyB0aGUgZm9sbG93aW5nIHRvIHRoZSBNaWNr ZXkgZHRzOgo+ID4gCj4gPiAmZW1tYyB7Cj4gPiAKPiA+IAkvZGVsZXRlLXByb3BlcnR5L21tYy1o czIwMC0xXzh2Owo+ID4gCj4gPiB9Owo+IAo+IFllcCwgbWF5YmUgd2UgcmVtb3ZlIHRoaXMgbm9k ZSBmaXJzdGx5IGJ1dCBzb21lb25lIGZpeCB0aGUgZW1tYyB0dW5lIGlzc3Vlcy4KCnllcCwgdGhh dCBpcyBkZWZpbml0bHkgdGhlIHBsYW4uIEkndmUgbm93IGFsc28gZG9uZSBtb3JlIHRoYW4gYSBk b3plbiByZWJvb3QgCnRlc3RzIG9uIG15IGJyYWluIGJvYXJkIGluY2x1ZGluZyBydW5uaW5nIGhk cGFybS1zcGVlZHRlc3RzIG9uIHRoZSBlbW1jIHRoZXJlLiAKVHVuaW5nIGFuZCBhbGwgcmVhZHMg ZGlkIHJ1biB3aXRob3V0IGFueSBoaWNrdXBzLCBzbyB0aGlzIHJlYWxseSBzZWVtcyB0byBiZSAK c29tZWhvdyBsaW1pdGVkLgoKCj4gPj4gQW55d2F5LCB0aGUgZHRzIGlzIGdvb2QgdG8gc3VwcG9y dCBtaWNrZXkgbWFjaGluZS4KPiA+PiBJIHRoaW5rIHRoZSBtbWMgdHVuZSBpcyBub3QgcHJlZmVj dCBpbiBtYWlubGluZS4KPiA+IAo+ID4geWVhaCwgaXQgc2VlbXMgd2Ugc3RpbGwgaGF2ZSBzb21l IGlzc3Vlcy4KPiA+IAo+ID4gQWx0aG91Z2ggaXQgc2VlbXMgb25seSB0aGUgZGlzbmV5LW1pY2Ug c2VlbSBhZmZlY3RlZCA7LSkgW21pbm5pZSBhbmQKPiA+IG1pY2tleV0uIFBpbmt5LCBCcmFpbiwg U3BlZWR5LCBKYXEgYWxsIHNlZW0gdG8gd29yayBzb21laG93IC0gYXQgbGVhc3QgSQo+ID4gaGF2 ZW4ndCBnb3R0ZW4gYW55IHJlcG9ydHMgYWJvdXQgdGhhdAo+IAo+IENjIHNoYXduLAo+IE1heWJl LCAgU2hhd25AUksgaGFzIHRoZSBpbnRlcmVzdGluZyBpbiBkZWJ1Z2luZyB0aGlzIGlzc3VlLjot KQoKU3RyYW5nZWx5IG9uIHRoZSBDaHJvbWVPUyBrZXJuZWwgdHVuaW5nIG9uIE1pbm5pZSBzZWVt cyB0byB3b3JrIG9rLiBJIGFscmVhZHkgCmNoZWNrZWQgdGhlIGNvZGUgc29tZXdoYXQgYW5kIHRo ZSBjb3JlIGhhbmRsaW5nIHNlZW1zIHRvIGJlIHRoZSBzYW1lIC0gbGlrZSAKdGhlIHBoYXNlIGNs b2NrcyBhbmQgdGhlIHR1bmluZyBhbGdvcml0aG0uCgpUaGUgb25seSBzbGlnaHQgZGlmZmVyZW5j ZSBpcyB0aGF0IG1haW5saW5lIGlzIHVzaW5nIG1tY19zZW5kX3R1bmluZygpIGluc3RlYWQgCm9m IGJ1aWxkaW5nIHRoZSBwYWNrZXQgYnkgaGFuZC4KCkJ1dCBhdCBsZWFzdCBvbiBteSBNaW5uaWUg dGhlIHBoYXNlcyB0aGUgZW1tYyBnZXRzIHR1bmVkIHRvIGFyZSBhbHdheXMgCmRpZmZlcmluZyBz b21laG93OiAobWFpbmxpbmU6IDIxNi0yMTgsIGNocm9tZW9zOiAxOTgtMjAxKSB3aGlsZSBvbiBt eSBqZXJyeSAKdGhlIHZhcmlhbmNlIGlzIG5vdCBhcyBiaWcgKG1haW5saW5lIDE3NiwgY2hyb21l b3M6IDE3MikuCgoKU29tZSBtb3JlIGNvbXBhcmlzb25zIEkgZGlkIG9uIE1pbm5pZToKc2RtbWM6 IHBoYXNlIDE5NyBvbiBib3RoIG1haW5saW5lIGFuZCBjaHJvbWVvcwp3aWZpOiBhcm91bmQgcGhh c2UgMjE0IG9uIG1haW5saW5lIGFuZCAyMDQgb24gY2hyb21lb3MKClNvIGF0IGxlYXN0IHRoZSBz ZG1tYyBob3N0IHNlZW1zIHByZXR0eSBzdGFibGUgaW4gaXRzIHBoYXNlIGFuZCB0aGUgZGlmZmVy ZW5jZSAKb24gd2lmaSBpcyBzbWFsbGVyIHRoYW4gd2l0aCB0aGUgZW1tYyAtIG5vdCBzdXJlIGlm IHRoYXQgaGVscHMgdGhvdWdoIDotKQoKCkknbGwgYWxzbyB0cnkgdG8gbG9vayBtb3JlIGludG8g dGhhdCBpc3N1ZSwgYnV0IHdvdWxkIGJlIGdsYWQgdG8gaGVhciBvdGhlciAKYnJpZ2h0IGlkZWFz IDotKQoKClRoYW5rcwpIZWlrbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Thu, 03 Dec 2015 15:00:33 +0100 Subject: [PATCH 3/3] ARM: dts: rockchip: add veyron-minnie board In-Reply-To: <566020EC.7060606@rock-chips.com> References: <2767415.mEkgRbSSUB@diego> <3359424.qNn8gsFXpA@diego> <566020EC.7060606@rock-chips.com> Message-ID: <2137537.DBrTyHZKX9@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Caesar, Shawn, Am Donnerstag, 3. Dezember 2015, 19:01:00 schrieb Caesar Wang: > ? 2015?12?03? 18:44, Heiko St?bner ??: > > Am Donnerstag, 3. Dezember 2015, 18:27:27 schrieb Caesar Wang: > >> .....but, > >> reboot long long test, that's seem mmc tune has a issue. > >> > >> 2.630892] mmcblk0: error -84 transferring data, sector 0, nr 8, cmd > >> > >> response 0x900, card status 0x0 > >> [ 2.631006] mmcblk0: error -110 sending status command, retrying > >> [ 2.631018] mmcblk0: error -84 transferring data, sector 1, nr 7, cmd > >> response 0x900, card status 0x0 > >> [ 2.631703] mmcblk0: unable to read partition table > >> ... > > > > Could you try if what we do on Minnie fixes that error (disabling tuning > > for now) - i.e. adding the following to the Mickey dts: > > > > &emmc { > > > > /delete-property/mmc-hs200-1_8v; > > > > }; > > Yep, maybe we remove this node firstly but someone fix the emmc tune issues. yep, that is definitly the plan. I've now also done more than a dozen reboot tests on my brain board including running hdparm-speedtests on the emmc there. Tuning and all reads did run without any hickups, so this really seems to be somehow limited. > >> Anyway, the dts is good to support mickey machine. > >> I think the mmc tune is not prefect in mainline. > > > > yeah, it seems we still have some issues. > > > > Although it seems only the disney-mice seem affected ;-) [minnie and > > mickey]. Pinky, Brain, Speedy, Jaq all seem to work somehow - at least I > > haven't gotten any reports about that > > Cc shawn, > Maybe, Shawn at RK has the interesting in debuging this issue.:-) Strangely on the ChromeOS kernel tuning on Minnie seems to work ok. I already checked the code somewhat and the core handling seems to be the same - like the phase clocks and the tuning algorithm. The only slight difference is that mainline is using mmc_send_tuning() instead of building the packet by hand. But at least on my Minnie the phases the emmc gets tuned to are always differing somehow: (mainline: 216-218, chromeos: 198-201) while on my jerry the variance is not as big (mainline 176, chromeos: 172). Some more comparisons I did on Minnie: sdmmc: phase 197 on both mainline and chromeos wifi: around phase 214 on mainline and 204 on chromeos So at least the sdmmc host seems pretty stable in its phase and the difference on wifi is smaller than with the emmc - not sure if that helps though :-) I'll also try to look more into that issue, but would be glad to hear other bright ideas :-) Thanks Heiko