From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 283E7C32750 for ; Fri, 2 Aug 2019 20:27:37 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id A6A52206A3 for ; Fri, 2 Aug 2019 20:27:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="iURawIek"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="0CB7f9M1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6A52206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E33B1C29F; Fri, 2 Aug 2019 22:27:35 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 87FDA1C205 for ; Fri, 2 Aug 2019 22:27:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1608C21F18; Fri, 2 Aug 2019 16:27:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 02 Aug 2019 16:27:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=nrLemVAPsVFo74UJloFr8R0vXfKy/xqIxg67wlcSb+k=; b=iURawIekPc0D JT0s14cqo77dshYqqt1Gep5jiGThFzAJJtIiYrIdWF0wtXVJ9bI0rOV3teZQ7zML 0Z+VDR9WkfP3EfDVvzqDzPRNLsHxNDtEN2prkXh7wy9RenZn0kN1Gn52BKehyiPU AeXKwE0dHP9D5HYXriihrRuXFRaxzWQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=nrLemVAPsVFo74UJloFr8R0vXfKy/xqIxg67wlcSb +k=; b=0CB7f9M1cWrzaI90z7us3U0pvw2vSTsncSV4hpAHJwkRAc5N89OdPXzRy LJUpmi3sU2V50jYCENy+388h/ArPgeN9NNEZCgBbKVsnAqH5KTQ/dM+qvOW+C6Wd VMP9PxTXxEig68y0PUcHcn8vaaFe2qU5Urvn2Vfv9K6+nNG4nzjy4XwkD9THDXGO Ts4Ri5C/V5lXke9qLrcKfGpIC5CcjUzc6O5BlhBidrNrwr65mpWKD7rgow+NuG+q FeivyAhLBx2uB8C95eeSGiTLTNootunLu9hClERiMx2cdAhq0YnVY1XGy4pWm6RS 0zlHSnTuijKlsJXpDrBtemhRPCcTA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleelgdduvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehshhgsrdgtihenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuve hluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 908C180059; Fri, 2 Aug 2019 16:27:32 -0400 (EDT) From: Thomas Monjalon To: Aaron Conole Cc: dev@dpdk.org, Michael Santana Francisco , David Marchand , Bruce Richardson , Ferruh Yigit , Luca Boccassi Date: Fri, 02 Aug 2019 22:27:31 +0200 Message-ID: <2139994.LeHafPJYVc@xps> In-Reply-To: References: <20190731145030.19956-1-aconole@redhat.com> <20190731145030.19956-3-aconole@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 31/07/2019 22:54, Michael Santana Francisco: > On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote: > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > @@ -22,3 +22,11 @@ fi > > OPTS="$OPTS --default-library=$DEF_LIB" > > meson build --werror -Dexamples=all $OPTS > > ninja -C build > > + > > +if [ "$RUN_TESTS" = "1" ]; then > > + # On the test build, also build the documentation, since it's expensive > > + # and we shouldn't need to build so much of it. > > + ninja -C build doc I am not sure to understand the comment. Do you mean you build the documentation only once, which is when running tests? Why it is not a new option similar as RUN_TESTS? > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -30,6 +30,7 @@ env: > > - DEF_LIB="shared" > > - DEF_LIB="static" OPTS="-Denable_kmods=false" > > - DEF_LIB="shared" OPTS="-Denable_kmods=false" > > + - DEF_LIB="shared" RUN_TESTS=1 > I don't agree with this. This is redundant. Why not put RUN_TESTS=1 on > an already exiting builds instead of adding two new builds like you > are doing here? I agree it is a strange logic. Why not use an existing build to run the tests?