From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] ethdev: add return value to stats get dev
	op
Date: Wed, 11 Oct 2017 15:14:28 +0200
Message-ID: <2142367.Av9Mkz2zTi@xps>
References: <1507565524-18590-1-git-send-email-matan@mellanox.com>
 <4271901.RE8S8KQ4zy@xps>
 <6b1e8d58-f570-dc28-4705-630788e6a04b@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, Matan Azrad <matan@mellanox.com>,
 dev@dpdk.org
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 87E3DF1F
 for <dev@dpdk.org>; Wed, 11 Oct 2017 15:14:30 +0200 (CEST)
In-Reply-To: <6b1e8d58-f570-dc28-4705-630788e6a04b@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/10/2017 15:09, Andrew Rybchenko:
> On 10/11/2017 01:46 PM, Thomas Monjalon wrote:
> > 11/10/2017 04:09, Ferruh Yigit:
> >> On 10/11/2017 3:01 AM, Ferruh Yigit wrote:
> >>> On 10/10/2017 9:20 PM, Matan Azrad wrote:
> >>>> The stats_get dev op API doesn't include return value, so PMD cannot
> >>>> return an error in case of failure at stats getting process time.
> >>>>
> >>>> Since PCI devices can be removed and there is a time between the
> >>>> physical removal to the RMV interrupt, the user may get invalid stats
> >>>> without any indication.
> >>>>
> >>>> This patch changes the stats_get API return value to be int instead of
> >>>> void.
> >>>>
> >>>> All the net PMDs stats_get dev ops are adjusted by this patch.
> >>>>
> >>>> Signed-off-by: Matan Azrad <matan@mellanox.com>
> >>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >> Applied to dpdk-next-net/master, thanks.
> > It is breaking compilation of tests:
> >
> > test/test/virtual_pmd.c:256:15: fatal error: incompatible pointer types
> >        initializing 'eth_stats_get_t' (aka 'int (*)(struct rte_eth_dev *, struct rte_eth_stats *)')
> >        with an expression of type 'void (struct rte_eth_dev *, struct rte_eth_stats *)'
> >        [-Wincompatible-pointer-types]
> >          .stats_get = virtual_ethdev_stats_get,
> 
> I've bumped into it this morning as well:
> http://dpdk.org/dev/patchwork/patch/30090/

Thank you Andrew.

Ferruh, please squash Andrew's patches to avoid any compilation issue.