From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v11 0/4] Hyper-V/Azure netvsc PMD and bus
	support
Date: Thu, 12 Jul 2018 21:55:04 +0200
Message-ID: <2142629.lVosk762JX@xps>
References: <20180612232939.24793-1-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4D61D5F3B
 for <dev@dpdk.org>; Thu, 12 Jul 2018 21:55:07 +0200 (CEST)
In-Reply-To: <20180612232939.24793-1-stephen@networkplumber.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The old offload API has been removed.
Please could you adapt this PMD to the new API?

The errors are:
=2E./drivers/net/netvsc/hn_ethdev.c:185:4: error: =E2=80=98struct rte_eth_t=
xconf=E2=80=99 has no member named =E2=80=98txq_flags=E2=80=99
=2E./drivers/net/netvsc/hn_ethdev.c:185:16: error: =E2=80=98ETH_TXQ_FLAGS_N=
OXSUMS=E2=80=99 undeclared (first use in this function)
   .txq_flags =3D ETH_TXQ_FLAGS_NOXSUMS,


Some checkpatches warnings are remaining:

### [dpdk-dev] [PATCH v11 2/4] bus/vmbus: add hyper-v virtual bus support

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#353: FILE: drivers/bus/vmbus/linux/vmbus_bus.c:28:
+extern struct rte_vmbus_bus rte_vmbus_bus;

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#2715: FILE: drivers/bus/vmbus/vmbus_common.c:26:
+extern struct rte_vmbus_bus rte_vmbus_bus;

### [dpdk-dev] [PATCH v11 3/4] net/netvsc: add hyper-v netvsc network device

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=3D' should be on the =
previous line
#519: FILE: drivers/net/netvsc/hn_ethdev.c:189:
+       dev_info->flow_type_rss_offloads
+               =3D ETH_RSS_IPV4 | ETH_RSS_IPV6 | ETH_RSS_TCP | ETH_RSS_UDP;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=3D' should be on the =
previous line
#622: FILE: drivers/net/netvsc/hn_ethdev.c:292:
+       const struct rte_eth_rss_conf *rss_conf
+               =3D &dev_conf->rx_adv_conf.rss_conf;

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#632: FILE: drivers/net/netvsc/hn_ethdev.c:302:
+                           "unsupported TX offload: %#" PRIx64,

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=3D' should be on the =
previous line
#788: FILE: drivers/net/netvsc/hn_ethdev.c:458:
+       const unsigned int nstats
+               =3D dev->data->nb_tx_queues * RTE_DIM(hn_stat_strings)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#2644: FILE: drivers/net/netvsc/hn_rndis.c:720:
+               PMD_DRV_LOG(ERR, "exec RNDIS set %#" PRIx32 " failed",

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=3D' should be on the =
previous line
#3500: FILE: drivers/net/netvsc/hn_rxtx.c:441:
+               struct rte_eth_dev *dev
+                       =3D &rte_eth_devices[rxq->port_id];