From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 06/13] virtio: read virtio_net_config correctly Date: Tue, 20 Oct 2015 09:07:49 +0200 Message-ID: <2143283.gKIdjTGCRD@xps13> References: <1444369572-1157-1-git-send-email-yuanhan.liu@linux.intel.com> <1444369572-1157-7-git-send-email-yuanhan.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, marcel@redhat.com, "Michael S. Tsirkin" To: Yuanhan Liu Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id DF8B38E97 for ; Tue, 20 Oct 2015 09:08:58 +0200 (CEST) Received: by wicfv8 with SMTP id fv8so13881241wic.0 for ; Tue, 20 Oct 2015 00:08:58 -0700 (PDT) In-Reply-To: <1444369572-1157-7-git-send-email-yuanhan.liu@linux.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-09 13:46, Yuanhan Liu: > From: Changchun Ouyang > > The old code adjusts the config bytes we want to read depending on > what kind of features we have, but we later cast the entire buf we > read with "struct virtio_net_config", which is obviously wrong. When describing a bug, it is important to explain what is the consequence, i.e. which use case is failing. If it is only to prepare the new feature, it is better to clearly state that the bug had no impact until now. And as usual, the "fix" word in the title and the "Fixes" tag are required.