From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:50720 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757613AbeD1QTT (ORCPT ); Sat, 28 Apr 2018 12:19:19 -0400 From: Laurent Pinchart To: jacopo mondi Cc: Laurent Pinchart , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham Subject: Re: [PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation Date: Sat, 28 Apr 2018 19:19:34 +0300 Message-ID: <2143831.DOFRIRY06f@avalon> In-Reply-To: <20180428100316.GC18201@w540> References: <20180422223430.16407-1-laurent.pinchart+renesas@ideasonboard.com> <20180422223430.16407-6-laurent.pinchart+renesas@ideasonboard.com> <20180428100316.GC18201@w540> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Jacopo, On Saturday, 28 April 2018 13:03:16 EEST jacopo mondi wrote: > Hi Laurent, > just one minor comment below > > On Mon, Apr 23, 2018 at 01:34:27AM +0300, Laurent Pinchart wrote: > > Add a parameter (in the form of a structure to ease future API > > extensions) to the VSP atomic flush handler to pass CRC source > > configuration, and pass the CRC value to the completion callback. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 6 ++++-- > > drivers/media/platform/vsp1/vsp1_drm.c | 6 ++++-- > > drivers/media/platform/vsp1/vsp1_drm.h | 2 +- > > include/media/vsp1.h | 29 +++++++++++++++++++++++++++-- > > 4 files changed, 36 insertions(+), 7 deletions(-) [snip] > > diff --git a/include/media/vsp1.h b/include/media/vsp1.h > > index ff7ef894465d..ac63a9928a79 100644 > > --- a/include/media/vsp1.h > > +++ b/include/media/vsp1.h [snip] > > @@ -61,11 +61,36 @@ struct vsp1_du_atomic_config { > > unsigned int zpos; > > }; > > > > +/** > > + * enum vsp1_du_crc_source - Source used for CRC calculation > > + * @VSP1_DU_CRC_NONE: CRC calculation disabled > > + * @VSP_DU_CRC_PLANE: Perform CRC calculation on an input plane > > + * @VSP_DU_CRC_OUTPUT: Perform CRC calculation on the composed output > > These two paramters are called VSP1_DU_CRC_* not VSP_DU_CRC_* My bad. I've fixed this in my tree but will wait for other review comments before posting a v3. > > + */ > > +enum vsp1_du_crc_source { > > + VSP1_DU_CRC_NONE, > > + VSP1_DU_CRC_PLANE, > > + VSP1_DU_CRC_OUTPUT, > > +}; [snip] -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation Date: Sat, 28 Apr 2018 19:19:34 +0300 Message-ID: <2143831.DOFRIRY06f@avalon> References: <20180422223430.16407-1-laurent.pinchart+renesas@ideasonboard.com> <20180422223430.16407-6-laurent.pinchart+renesas@ideasonboard.com> <20180428100316.GC18201@w540> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E3726E156 for ; Sat, 28 Apr 2018 16:19:19 +0000 (UTC) In-Reply-To: <20180428100316.GC18201@w540> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: jacopo mondi Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , Kieran Bingham , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgSmFjb3BvLAoKT24gU2F0dXJkYXksIDI4IEFwcmlsIDIwMTggMTM6MDM6MTYgRUVTVCBqYWNv cG8gbW9uZGkgd3JvdGU6Cj4gSGkgTGF1cmVudCwKPiAgICBqdXN0IG9uZSBtaW5vciBjb21tZW50 IGJlbG93Cj4gCj4gT24gTW9uLCBBcHIgMjMsIDIwMTggYXQgMDE6MzQ6MjdBTSArMDMwMCwgTGF1 cmVudCBQaW5jaGFydCB3cm90ZToKPiA+IEFkZCBhIHBhcmFtZXRlciAoaW4gdGhlIGZvcm0gb2Yg YSBzdHJ1Y3R1cmUgdG8gZWFzZSBmdXR1cmUgQVBJCj4gPiBleHRlbnNpb25zKSB0byB0aGUgVlNQ IGF0b21pYyBmbHVzaCBoYW5kbGVyIHRvIHBhc3MgQ1JDIHNvdXJjZQo+ID4gY29uZmlndXJhdGlv biwgYW5kIHBhc3MgdGhlIENSQyB2YWx1ZSB0byB0aGUgY29tcGxldGlvbiBjYWxsYmFjay4KPiA+ IAo+ID4gU2lnbmVkLW9mZi1ieTogTGF1cmVudCBQaW5jaGFydAo+ID4gPGxhdXJlbnQucGluY2hh cnQrcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgo+ID4gLS0tCj4gPiAKPiA+ICBkcml2ZXJzL2dw dS9kcm0vcmNhci1kdS9yY2FyX2R1X3ZzcC5jICB8ICA2ICsrKystLQo+ID4gIGRyaXZlcnMvbWVk aWEvcGxhdGZvcm0vdnNwMS92c3AxX2RybS5jIHwgIDYgKysrKy0tCj4gPiAgZHJpdmVycy9tZWRp YS9wbGF0Zm9ybS92c3AxL3ZzcDFfZHJtLmggfCAgMiArLQo+ID4gIGluY2x1ZGUvbWVkaWEvdnNw MS5oICAgICAgICAgICAgICAgICAgIHwgMjkgKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0K PiA+ICA0IGZpbGVzIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpb c25pcF0KCj4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9tZWRpYS92c3AxLmggYi9pbmNsdWRlL21l ZGlhL3ZzcDEuaAo+ID4gaW5kZXggZmY3ZWY4OTQ0NjVkLi5hYzYzYTk5MjhhNzkgMTAwNjQ0Cj4g PiAtLS0gYS9pbmNsdWRlL21lZGlhL3ZzcDEuaAo+ID4gKysrIGIvaW5jbHVkZS9tZWRpYS92c3Ax LmgKCltzbmlwXQoKPiA+IEBAIC02MSwxMSArNjEsMzYgQEAgc3RydWN0IHZzcDFfZHVfYXRvbWlj X2NvbmZpZyB7Cj4gPiAgCXVuc2lnbmVkIGludCB6cG9zOwo+ID4gIH07Cj4gPiAKPiA+ICsvKioK PiA+ICsgKiBlbnVtIHZzcDFfZHVfY3JjX3NvdXJjZSAtIFNvdXJjZSB1c2VkIGZvciBDUkMgY2Fs Y3VsYXRpb24KPiA+ICsgKiBAVlNQMV9EVV9DUkNfTk9ORTogQ1JDIGNhbGN1bGF0aW9uIGRpc2Fi bGVkCj4gPiArICogQFZTUF9EVV9DUkNfUExBTkU6IFBlcmZvcm0gQ1JDIGNhbGN1bGF0aW9uIG9u IGFuIGlucHV0IHBsYW5lCj4gPiArICogQFZTUF9EVV9DUkNfT1VUUFVUOiBQZXJmb3JtIENSQyBj YWxjdWxhdGlvbiBvbiB0aGUgY29tcG9zZWQgb3V0cHV0Cj4gCj4gVGhlc2UgdHdvIHBhcmFtdGVy cyBhcmUgY2FsbGVkIFZTUDFfRFVfQ1JDXyogbm90IFZTUF9EVV9DUkNfKgoKTXkgYmFkLiBJJ3Zl IGZpeGVkIHRoaXMgaW4gbXkgdHJlZSBidXQgd2lsbCB3YWl0IGZvciBvdGhlciByZXZpZXcgY29t bWVudHMgCmJlZm9yZSBwb3N0aW5nIGEgdjMuCgo+ID4gKyAqLwo+ID4gK2VudW0gdnNwMV9kdV9j cmNfc291cmNlIHsKPiA+ICsJVlNQMV9EVV9DUkNfTk9ORSwKPiA+ICsJVlNQMV9EVV9DUkNfUExB TkUsCj4gPiArCVZTUDFfRFVfQ1JDX09VVFBVVCwKPiA+ICt9OwoKW3NuaXBdCgotLSAKUmVnYXJk cywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==