Re: [PATCH v1 3/3] tests/functional/s390x/test_secure_ipl: Add virtio-blk-pci boot dev case

[Matthew Rosato <mjrosato@linux.ibm.com>]

>> Unless this is really time consuming, I think the simple answer is to
>> just let the setup run twice and don't try to share between the 2
>> instances?
>>
>> Thanks,
>> Matt
>>
> The setup is time consuming compared to the verification step. On my
> machine, the entire test takes about 120s, and about 90% of that is setup.

Bleh.  OK, that seems worth the extra complexity.

> 
> A simple solution is to scrap the subtest idea and just have:
> 
> @skipBigDataTest()
> def test_s390x_secure_ipl(self):
>     self.require_accelerator('kvm')
>     self.setup_s390x_secure_ipl()
>     self.verify_s390x_secure_ipl('ccw')
>     self.verify_s390x_secure_ipl('pci')
> 
> But if we value separating the ccw and pci cases into separate subtests,
> I have a solution using setUpClass() and class-level vars to run the
> setup only once. It just makes the code a bit uglier. I'll proceed with
> it for v2, unless other opinions arise.
Sounds good.

Thanks,
Matt