From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michael Qiu <michael.qiu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] test-pmd: show pci address in port info
Date: Wed, 29 Jul 2015 10:42:51 +0200 [thread overview]
Message-ID: <2144726.adBAHMgyBQ@xps13> (raw)
In-Reply-To: <1438131904-23221-1-git-send-email-michael.qiu@intel.com>
2015-07-29 09:05, Michael Qiu:
> pci address is one important info for port.
> This patch make it visible for port info.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
Maybe you missed this thread:
http://dpdk.org/ml/archives/dev/2015-July/022107.html
> + if (strncmp("0000:00:00.0", pci_addr, 12))
> + printf("\nPCI address: %s", pci_addr);
> + else
> + printf("\nPCI address: N/A");
Checking a null PCI address to handle non-pci devices is ugly.
EAL must be reworked to correctly handle non-PCI devices.
Patches welcome.
This patch is rejected.
prev parent reply other threads:[~2015-07-29 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 1:05 [PATCH] test-pmd: show pci address in port info Michael Qiu
2015-07-29 8:42 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2144726.adBAHMgyBQ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.