From: Thomas Monjalon <thomas@monjalon.net>
To: jiayu.hu@intel.com
Cc: dev@dpdk.org, Kumara Parameshwaran <kumaraparamesh92@gmail.com>,
Kumara Parameshwaran <kparameshwar@vmware.com>,
Kumara Parameshwaran <kumaraparamesh92@gmail.com>
Subject: Re: [PATCH v5] gro : fix reordering of packets in GRO library
Date: Mon, 19 Jun 2023 15:25:15 +0200 [thread overview]
Message-ID: <2145514.irdbgypaU6@thomas> (raw)
In-Reply-To: <20221101070557.58808-1-kumaraparmesh92@gmail.com>
01/11/2022 08:05, Kumara Parameshwaran:
> From: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
>
> When a TCP packet contains flags like PSH it is returned
> immediately to the application though there might be packets of
> the same flow in the GRO table. If PSH flag is set on a segment
> packets up to the segment should be delivered immediately. But the
> current implementation delivers the last arrived packet with PSH flag
> set causing re-ordering
>
> With this patch, if a packet does not contain only ACK flag and if
> there are no previous packets for the flow the packet would be returned
> immediately, else will be merged with the previous segment and the
> flag on the last segment will be set on the entire segment.
> This is the behaviour with linux stack as well.
>
> Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> Co-authored-by: Kumara Parameshwaran <kparameshwar@vmware.com>
This is yourself, right?
Please choose one email address and use it in your git config.
Jiayu, any comment about the patch content?
next prev parent reply other threads:[~2023-06-19 13:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 10:18 [PATCH] gro : fix reordering of packets in GRO library Kumara Parameshwaran
2022-10-13 10:20 ` kumaraparameshwaran rathinavel
2022-10-28 8:09 ` [PATCH v2] " Kumara Parameshwaran
2022-10-28 8:27 ` [PATCH v3] " Kumara Parameshwaran
2022-10-28 9:51 ` [PATCH v4] " Kumara Parameshwaran
2022-11-01 7:05 ` [PATCH v5] " Kumara Parameshwaran
2023-06-19 13:25 ` Thomas Monjalon [this message]
2023-06-20 7:35 ` Hu, Jiayu
2023-06-21 8:47 ` kumaraparameshwaran rathinavel
2023-06-30 11:32 ` kumaraparameshwaran rathinavel
2023-12-08 17:54 ` [PATCH v6] gro: fix reordering of packets in GRO layer Kumara Parameshwaran
2023-12-08 18:05 ` [PATCH v7] " Kumara Parameshwaran
2023-12-08 18:12 ` [PATCH v8] " Kumara Parameshwaran
2023-12-08 18:17 ` [PATCH v9] " Kumara Parameshwaran
2024-01-04 15:49 ` 胡嘉瑜
2024-01-07 11:21 ` [PATCH v10] " Kumara Parameshwaran
2024-01-07 11:29 ` [PATCH v11] " Kumara Parameshwaran
2024-01-07 17:20 ` Stephen Hemminger
2024-01-08 16:11 ` kumaraparameshwaran rathinavel
2024-01-08 15:50 ` [PATCH v12] " Kumara Parameshwaran
2024-01-08 16:04 ` [PATCH v13] " Kumara Parameshwaran
2024-01-16 14:28 ` 胡嘉瑜
2024-02-12 14:30 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2022-09-07 8:59 [PATCH] gro: fix the chain index in insert_new_item for more than 2 packets Kumara Parameshwaran
2022-11-01 7:03 ` [PATCH v5] gro : fix reordering of packets in GRO library Kumara Parameshwaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2145514.irdbgypaU6@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=kparameshwar@vmware.com \
--cc=kumaraparamesh92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.