diff for duplicates of <2148581.S8tzak9aE2@uw000953> diff --git a/a/1.txt b/N1/1.txt index 95b5f17..898787f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,8 +4,8 @@ On Thursday 31 of January 2013 10:16:46 Dan Carpenter wrote: > If gb_len is less than 3 it would cause an integer underflow and > possibly memory corruption in nfc_llcp_parse_gb_tlv(). > -> I removed the old test for gb_len = 0. I also removed the test for -> ->remote_gb = NULL. It's not possible for ->remote_gb to be NULL and +> I removed the old test for gb_len == 0. I also removed the test for +> ->remote_gb == NULL. It's not possible for ->remote_gb to be NULL and > we have already dereferenced ->remote_gb_len so it's too late to test. > > The old test return -ENODEV but my test returns -EINVAL. @@ -31,7 +31,7 @@ nfc_set_remote_general_bytes() ? > memcpy(local->remote_gb, gb, gb_len); > local->remote_gb_len = gb_len; > -> - if (local->remote_gb = NULL || local->remote_gb_len = 0) +> - if (local->remote_gb == NULL || local->remote_gb_len == 0) > - return -ENODEV; > - > if (memcmp(local->remote_gb, llcp_magic, 3)) { diff --git a/a/content_digest b/N1/content_digest index 2ba69f3..e49115d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020130131081645.GA14812@elgon.mountain\0" "From\0Szymon Janc <szymon.janc@tieto.com>\0" "Subject\0Re: [patch] NFC: llcp: integer underflow in nfc_llcp_set_remote_gb()\0" - "Date\0Thu, 07 Feb 2013 10:16:01 +0000\0" + "Date\0Thu, 7 Feb 2013 11:16:01 +0100\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Lauro Ramos Venancio <lauro.venancio@openbossa.org>" Aloisio Almeida Jr <aloisio.almeida@openbossa.org> @@ -21,8 +21,8 @@ "> If gb_len is less than 3 it would cause an integer underflow and\n" "> possibly memory corruption in nfc_llcp_parse_gb_tlv().\n" "> \n" - "> I removed the old test for gb_len = 0. I also removed the test for\n" - "> ->remote_gb = NULL. It's not possible for ->remote_gb to be NULL and\n" + "> I removed the old test for gb_len == 0. I also removed the test for\n" + "> ->remote_gb == NULL. It's not possible for ->remote_gb to be NULL and\n" "> we have already dereferenced ->remote_gb_len so it's too late to test.\n" "> \n" "> The old test return -ENODEV but my test returns -EINVAL.\n" @@ -48,7 +48,7 @@ "> \tmemcpy(local->remote_gb, gb, gb_len);\n" "> \tlocal->remote_gb_len = gb_len;\n" "> \n" - "> -\tif (local->remote_gb = NULL || local->remote_gb_len = 0)\n" + "> -\tif (local->remote_gb == NULL || local->remote_gb_len == 0)\n" "> -\t\treturn -ENODEV;\n" "> -\n" "> \tif (memcmp(local->remote_gb, llcp_magic, 3)) {\n" @@ -59,4 +59,4 @@ "BR\n" Szymon Janc -7dfacc185672c497b46c954b385c5f0704c2e7eb5a1cb047fcc5f604b9ad70db +adf2042383a8426ffdc7b0f3c1c94d65ab5c116d374b1b9a892c9bde975e9963
diff --git a/a/1.txt b/N2/1.txt index 95b5f17..a70b331 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -4,13 +4,13 @@ On Thursday 31 of January 2013 10:16:46 Dan Carpenter wrote: > If gb_len is less than 3 it would cause an integer underflow and > possibly memory corruption in nfc_llcp_parse_gb_tlv(). > -> I removed the old test for gb_len = 0. I also removed the test for -> ->remote_gb = NULL. It's not possible for ->remote_gb to be NULL and +> I removed the old test for gb_len == 0. I also removed the test for +> ->remote_gb == NULL. It's not possible for ->remote_gb to be NULL and > we have already dereferenced ->remote_gb_len so it's too late to test. > > The old test return -ENODEV but my test returns -EINVAL. > -> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > > diff --git a/net/nfc/llcp/llcp.c b/net/nfc/llcp/llcp.c > index 85bc75c..746f5a2 100644 @@ -31,7 +31,7 @@ nfc_set_remote_general_bytes() ? > memcpy(local->remote_gb, gb, gb_len); > local->remote_gb_len = gb_len; > -> - if (local->remote_gb = NULL || local->remote_gb_len = 0) +> - if (local->remote_gb == NULL || local->remote_gb_len == 0) > - return -ENODEV; > - > if (memcmp(local->remote_gb, llcp_magic, 3)) { @@ -41,3 +41,7 @@ nfc_set_remote_general_bytes() ? -- BR Szymon Janc +-- +To unsubscribe from this list: send the line "unsubscribe linux-wireless" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 2ba69f3..58ac1f0 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,18 +1,19 @@ "ref\020130131081645.GA14812@elgon.mountain\0" - "From\0Szymon Janc <szymon.janc@tieto.com>\0" + "ref\020130131081645.GA14812-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org\0" + "From\0Szymon Janc <szymon.janc-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org>\0" "Subject\0Re: [patch] NFC: llcp: integer underflow in nfc_llcp_set_remote_gb()\0" - "Date\0Thu, 07 Feb 2013 10:16:01 +0000\0" - "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Cc\0Lauro Ramos Venancio <lauro.venancio@openbossa.org>" - Aloisio Almeida Jr <aloisio.almeida@openbossa.org> - Samuel Ortiz <sameo@linux.intel.com> - David S. Miller <davem@davemloft.net> - John W. Linville <linville@tuxdriver.com> - Thierry Escande <thierry.escande@linux.intel.com> - linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org> - linux-nfc@ml01.01.org <linux-nfc@ml01.01.org> - netdev@vger.kernel.org <netdev@vger.kernel.org> - " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" + "Date\0Thu, 7 Feb 2013 11:16:01 +0100\0" + "To\0Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>\0" + "Cc\0Lauro Ramos Venancio <lauro.venancio-430g2QfJUUCGglJvpFV4uA@public.gmane.org>" + Aloisio Almeida Jr <aloisio.almeida-430g2QfJUUCGglJvpFV4uA@public.gmane.org> + Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> + David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> + John W. Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org> + Thierry Escande <thierry.escande-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> + linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> + linux-nfc-y27Ovi1pjclAfugRpC6u6w@public.gmane.org <linux-nfc-y27Ovi1pjclAfugRpC6u6w@public.gmane.org> + netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> + " kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" "\00:1\0" "b\0" "Hi Dan,\n" @@ -21,13 +22,13 @@ "> If gb_len is less than 3 it would cause an integer underflow and\n" "> possibly memory corruption in nfc_llcp_parse_gb_tlv().\n" "> \n" - "> I removed the old test for gb_len = 0. I also removed the test for\n" - "> ->remote_gb = NULL. It's not possible for ->remote_gb to be NULL and\n" + "> I removed the old test for gb_len == 0. I also removed the test for\n" + "> ->remote_gb == NULL. It's not possible for ->remote_gb to be NULL and\n" "> we have already dereferenced ->remote_gb_len so it's too late to test.\n" "> \n" "> The old test return -ENODEV but my test returns -EINVAL.\n" "> \n" - "> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>\n" "> \n" "> diff --git a/net/nfc/llcp/llcp.c b/net/nfc/llcp/llcp.c\n" "> index 85bc75c..746f5a2 100644\n" @@ -48,7 +49,7 @@ "> \tmemcpy(local->remote_gb, gb, gb_len);\n" "> \tlocal->remote_gb_len = gb_len;\n" "> \n" - "> -\tif (local->remote_gb = NULL || local->remote_gb_len = 0)\n" + "> -\tif (local->remote_gb == NULL || local->remote_gb_len == 0)\n" "> -\t\treturn -ENODEV;\n" "> -\n" "> \tif (memcmp(local->remote_gb, llcp_magic, 3)) {\n" @@ -57,6 +58,10 @@ "\n" "-- \n" "BR\n" - Szymon Janc + "Szymon Janc\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-wireless\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -7dfacc185672c497b46c954b385c5f0704c2e7eb5a1cb047fcc5f604b9ad70db +934a5c1f7575e6cdb2131595da87e7d4a8544384b47641867c0e4c41b765f41a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.