From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] Move mk/rte.extvars.mk to mk/internal/rte.extvars.mk
Date: Sat, 07 Mar 2015 21:38:47 +0100 [thread overview]
Message-ID: <2151096.y3SmQntZBq@xps13> (raw)
In-Reply-To: <54F96951.2060406-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-03-06 09:46, Olivier MATZ:
> Hi Keith,
>
> On 03/04/2015 06:13 PM, Keith Wiles wrote:
> > Move the rte.extvars.mk to an internal directory and
> > update rte.vars.mk to find the file in the new location.
> >
> > Signed-off-by: Keith Wiles <keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> (for after 2.0 I guess as it's not a fix)
It's a good clean-up without risk. It should go in.
> Note for Thomas: when you apply it, git complains there is a blank
> line at the end of the file that is moved, I think you can strip it:
>
> dpdk/.git/rebase-apply/patch:94: new blank line at EOF.
> +
OK, thanks
next prev parent reply other threads:[~2015-03-07 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 17:13 [PATCH] Move mk/rte.extvars.mk to mk/internal/rte.extvars.mk Keith Wiles
[not found] ` <1425489189-43477-1-git-send-email-keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-06 8:46 ` Olivier MATZ
[not found] ` <54F96951.2060406-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-03-07 20:38 ` Thomas Monjalon [this message]
2015-03-09 11:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2151096.y3SmQntZBq@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.