From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: PATCH [1/1]: audit: acquire creds selectively to reduce atomic op overhead Date: Tue, 15 Mar 2011 20:11:17 +0000 Message-ID: <21526.1300219877@redhat.com> References: <1300211077.3748.2.camel@localhost.localdomain> <20110310202516.GA16122@suse.de> <20110307210656.GA1750@suse.de> <18893.1299607373@redhat.com> <29980.1299861232@redhat.com> <20110315173810.GA12775@suse.de> Return-path: In-Reply-To: <1300211077.3748.2.camel@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org To: Eric Paris Cc: dhowells@redhat.com, Tony Jones , linux-kernel@vger.kernel.org, linux-audit@redhat.com, Al Viro List-Id: linux-audit@redhat.com Eric Paris wrote: > WARN_ON(cred != current->cred && cred->refcnt != 1) 'tsk->parent == current' perhaps? Or audit_alloc() could pass a flag indicating the state, or just look to see if tsk->audit_context is still NULL. David