From: Valdis.Kletnieks@vt.edu
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] vfs: only add " (deleted)" where necessary
Date: Mon, 02 Aug 2010 09:00:56 -0400 [thread overview]
Message-ID: <215565.1280754056@localhost> (raw)
In-Reply-To: Your message of "Mon, 02 Aug 2010 13:20:01 +0200." <20100802112024.851698363@szeredi.hu>
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
On Mon, 02 Aug 2010 13:20:01 +0200, Miklos Szeredi said:
> Index: linux-2.6/fs/dcache.c
> ===================================================================
> --- linux-2.6.orig/fs/dcache.c 2010-07-06 18:08:16.000000000 +0200
> +++ linux-2.6/fs/dcache.c 2010-07-06 18:08:19.000000000 +0200
> @@ -1977,8 +1977,7 @@ global_root:
> * @buffer: buffer to return value in
> * @buflen: buffer length
> *
> - * Convert a dentry into an ASCII path name. If the entry has been deleted
> - * the string " (deleted)" is appended. Note that this is ambiguous.
> + * Convert a dentry into an ASCII path name.
> *
> * Returns a pointer into the buffer or an error code if the
> * path was too long.
I'd prefer the comment about it being ambiguous remain. I'm waiting to see how
long it takes for somebody to create a security hole by creating a file called
'/etc/some/thing/important (deleted)' and having some software Do The Wrong
Thing instead to /etc/some/thing/important.
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2010-08-02 13:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 11:19 [PATCH 0/7] dcache fixes and cleanups Miklos Szeredi
2010-08-02 11:19 ` [PATCH 1/7] cachefiles: use path_get instead of lone dget Miklos Szeredi
2010-08-04 10:23 ` David Howells
2010-08-02 11:19 ` [PATCH 2/7] vfs: add helpers to get root and pwd Miklos Szeredi
2010-08-02 11:19 ` [PATCH 3/7] ia64: perfmon: add d_dname method Miklos Szeredi
2010-08-02 11:19 ` [PATCH 4/7] vfs: __d_path: dont prepend the name of the root dentry Miklos Szeredi
2010-08-02 11:20 ` [PATCH 5/7] vfs: add prepend_path() helper Miklos Szeredi
2010-08-02 11:20 ` [PATCH 6/7] vfs: only add " (deleted)" where necessary Miklos Szeredi
2010-08-02 13:00 ` Valdis.Kletnieks [this message]
2010-08-02 13:21 ` Bastien ROUCARIES
2010-08-02 13:37 ` Miklos Szeredi
2010-08-02 13:35 ` Miklos Szeredi
2010-08-02 15:11 ` Valdis.Kletnieks
2010-08-02 11:20 ` [PATCH 7/7] vfs: show unreachable paths in getcwd and proc Miklos Szeredi
-- strict thread matches above, loose matches on Subject: below --
2010-08-10 9:41 [PATCH 0/7] dcache fixes and cleanups Miklos Szeredi
2010-08-10 9:41 ` [PATCH 6/7] vfs: only add " (deleted)" where necessary Miklos Szeredi
2010-07-06 17:40 [PATCH 0/7] dcache fixes and cleanups Miklos Szeredi
2010-07-06 17:40 ` [PATCH 6/7] vfs: only add " (deleted)" where necessary Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=215565.1280754056@localhost \
--to=valdis.kletnieks@vt.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.