From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible Date: Sat, 31 Oct 2015 00:47:11 +0100 Message-ID: <21587719.mnFBFBzBeI@phil> References: <1443147298-12603-1-git-send-email-wxt@rock-chips.com> <5632E765.4010207@gmail.com> <56334995.6090103@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56334995.6090103-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Daniel Lezcano Cc: Caesar Wang , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Caesar Wang List-Id: linux-rockchip.vger.kernel.org SGkgRGFuaWVsLAoKQW0gRnJlaXRhZywgMzAuIE9rdG9iZXIgMjAxNSwgMTE6NDI6Mjkgc2Nocmll YiBEYW5pZWwgTGV6Y2FubzoKPiBPbiAxMC8zMC8yMDE1IDA0OjQzIEFNLCBDYWVzYXIgV2FuZyB3 cm90ZToKPiA+IEhpIERhbmllbCwKPiA+Cj4gPiDlnKggMjAxNeW5tDEw5pyIMDHml6UgMDM6MTQs IEhlaWtvIFN0w7xibmVyIOWGmemBkzoKPiA+PiBIaSBEYW5pZWwsCj4gPj4KPiA+PiBBbSBEaWVu c3RhZywgMjkuIFNlcHRlbWJlciAyMDE1LCAwNjoxODowMyBzY2hyaWViIERhbmllbCBMZXpjYW5v Ogo+ID4+PiBPbiAwOS8yNS8yMDE1IDA0OjE0IEFNLCBDYWVzYXIgV2FuZyB3cm90ZToKPiA+Pj4+ IEJ1aWxkIHRoZSBhcm02NCBTb0NzIChlLmcuOiBSSzMzNjgpIG9uIFJvY2tjaGlwIHBsYXRmb3Jt LAo+ID4+Pj4gVGhlcmUgYXJlIHNvbWUgZmFpbHVyZSB3aXRoIGJ1aWxkIHVwIG9uIHRpbWVyIGRy aXZlciBmb3Igcm9ja2NoaXAuCj4gPj4+Pgo+ID4+Pj4gU2F5czoKPiA+Pj4+IC90bXAvY2NkQW5O eTUuczo0NzogRXJyb3I6IG1pc3NpbmcgaW1tZWRpYXRlIGV4cHJlc3Npb24gYXQgIG9wZXJhbmQK PiA+Pj4+IDEgLS0KPiA+Pj4+IGBkc2JgCj4gPj4+PiAuLi4KPiA+Pj4+Cj4gPj4+PiBUaGUgcHJv YmxlbSB3YXMgZGlmZmVyZW50IHNlbWFudGljcyBvZiBkc2Igb24gYnR3IGFybTMyIGFuZCBhcm02 NCwKPiA+Pj4+IEhlcmUgd2UgY2FuIGNvbnZlcnQgdGhlIGRzYiB3aXRoIGluc3RlYWRpbmcgb2Yg ZHNiKHN5KS5UaGUgInN5IiBwYXJhbQo+ID4+Pj4gaXMgdGhlIGRlZmF1bHQgd2hpY2ggeW91IGFy ZSBhbGxvdyB0byBvbWl0LCBzbyBvbiBhcm0zMiBkc2IoKWFuZAo+ID4+Pj4gZHNiKHN5KQo+ID4+ Pj4gYXJlIHRoZSBzYW1lLgo+ID4+Pj4KPiA+Pj4+IFNpZ25lZC1vZmYtYnk6IENhZXNhciBXYW5n IDx3eHRAcm9jay1jaGlwcy5jb20+Cj4gPj4+IEFja2VkLWJ5OiBEYW5pZWwgTGV6Y2FubyA8ZGFu aWVsLmxlemNhbm9AbGluYXJvLm9yZz4KPiA+PiBhcyB5b3UgaGF2ZSAianVzdCIgQWNrZWQgdGhl c2UgcGF0Y2hlcywgSSBndWVzcyB5b3UgYXJlIGV4cGVjdGluZyB0aGVtCj4gPj4gdG8gZ28KPiA+ PiB0aHJvdWdoIHRoZSBzYW1lIHRyZWUgYXMgdGhlIGRldmljZXRyZWUgY2hhbmdlcywgcmlnaHQ/ Cj4gPgo+ID4gSSdtIHdvbmRlciBpZiBzb21lb25lIHdpbGwgYXBwbHkgdGhpcyBzZXJpZXMgcGF0 Y2hzIGJ1dCB0aGUgd2FpdC46LSkKPiA+IEluIGZhY3QsIEknbSBubyBzdXJlIHRoYXQgdGhlIEFj a2VkIGlzIHJlYWxseSBtZWFuaW5nLjotCj4gCj4gWWVzLCBieSBhY2tpbmcgdGhlIHBhdGNoIEkg c2F5IEkgYW0gb2sgd2l0aCBpdCBhbmQgSSBhZ3JlZSBpdCBjYW4gZ28gCj4gdGhyb3VnaCBhbm90 aGVyIHRyZWUuCgphbHRob3VnaCBJIGd1ZXNzIHRoZSB0d28gY2xvY2tzb3VyY2UgY2hhbmdlcyBj b3VsZCB2ZXJ5IHdlbGwganVzdCBnbwp0aHJvdWdoIHlvdXIgdHJlZS4gZHNiKCkgLT4gZHNiKHN5 KSBpcyBzdXBwb3NlZCB0byBiZSBlcXVhbCBhbmQgdGhlIHNlY29uZApvbmUgaXMganVzdCBjb3Nt ZXRpY3MuICBUaGUgS2NvbmZpZyBhbmQgZHRzIGNoYW5nZXMgbmVlZCB0byB3YWl0IGluIGFueSBj YXNlCmZvciA0LjUgLi4uIGJ1dCBJIGd1ZXNzIHRoYXQgbWF5IGJlIHRydWUgZm9yIHRoZSBjbG9j a3NvdXJjZSBjaGFuZ2VzIGFzIHdlbGw/CgoKSGVpa28KCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGlu dXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Sat, 31 Oct 2015 00:47:11 +0100 Subject: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible In-Reply-To: <56334995.6090103@linaro.org> References: <1443147298-12603-1-git-send-email-wxt@rock-chips.com> <5632E765.4010207@gmail.com> <56334995.6090103@linaro.org> Message-ID: <21587719.mnFBFBzBeI@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Daniel, Am Freitag, 30. Oktober 2015, 11:42:29 schrieb Daniel Lezcano: > On 10/30/2015 04:43 AM, Caesar Wang wrote: > > Hi Daniel, > > > > ? 2015?10?01? 03:14, Heiko St?bner ??: > >> Hi Daniel, > >> > >> Am Dienstag, 29. September 2015, 06:18:03 schrieb Daniel Lezcano: > >>> On 09/25/2015 04:14 AM, Caesar Wang wrote: > >>>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform, > >>>> There are some failure with build up on timer driver for rockchip. > >>>> > >>>> Says: > >>>> /tmp/ccdAnNy5.s:47: Error: missing immediate expression at operand > >>>> 1 -- > >>>> `dsb` > >>>> ... > >>>> > >>>> The problem was different semantics of dsb on btw arm32 and arm64, > >>>> Here we can convert the dsb with insteading of dsb(sy).The "sy" param > >>>> is the default which you are allow to omit, so on arm32 dsb()and > >>>> dsb(sy) > >>>> are the same. > >>>> > >>>> Signed-off-by: Caesar Wang > >>> Acked-by: Daniel Lezcano > >> as you have "just" Acked these patches, I guess you are expecting them > >> to go > >> through the same tree as the devicetree changes, right? > > > > I'm wonder if someone will apply this series patchs but the wait.:-) > > In fact, I'm no sure that the Acked is really meaning.:- > > Yes, by acking the patch I say I am ok with it and I agree it can go > through another tree. although I guess the two clocksource changes could very well just go through your tree. dsb() -> dsb(sy) is supposed to be equal and the second one is just cosmetics. The Kconfig and dts changes need to wait in any case for 4.5 ... but I guess that may be true for the clocksource changes as well? Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753073AbbJaAX4 (ORCPT ); Fri, 30 Oct 2015 20:23:56 -0400 Received: from gloria.sntech.de ([95.129.55.99]:45748 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751981AbbJaAXx convert rfc822-to-8bit (ORCPT ); Fri, 30 Oct 2015 20:23:53 -0400 From: Heiko Stuebner To: Daniel Lezcano Cc: Caesar Wang , devicetree@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Caesar Wang Subject: Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible Date: Sat, 31 Oct 2015 00:47:11 +0100 Message-ID: <21587719.mnFBFBzBeI@phil> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; ) In-Reply-To: <56334995.6090103@linaro.org> References: <1443147298-12603-1-git-send-email-wxt@rock-chips.com> <5632E765.4010207@gmail.com> <56334995.6090103@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Am Freitag, 30. Oktober 2015, 11:42:29 schrieb Daniel Lezcano: > On 10/30/2015 04:43 AM, Caesar Wang wrote: > > Hi Daniel, > > > > 在 2015年10月01日 03:14, Heiko Stübner 写道: > >> Hi Daniel, > >> > >> Am Dienstag, 29. September 2015, 06:18:03 schrieb Daniel Lezcano: > >>> On 09/25/2015 04:14 AM, Caesar Wang wrote: > >>>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform, > >>>> There are some failure with build up on timer driver for rockchip. > >>>> > >>>> Says: > >>>> /tmp/ccdAnNy5.s:47: Error: missing immediate expression at operand > >>>> 1 -- > >>>> `dsb` > >>>> ... > >>>> > >>>> The problem was different semantics of dsb on btw arm32 and arm64, > >>>> Here we can convert the dsb with insteading of dsb(sy).The "sy" param > >>>> is the default which you are allow to omit, so on arm32 dsb()and > >>>> dsb(sy) > >>>> are the same. > >>>> > >>>> Signed-off-by: Caesar Wang > >>> Acked-by: Daniel Lezcano > >> as you have "just" Acked these patches, I guess you are expecting them > >> to go > >> through the same tree as the devicetree changes, right? > > > > I'm wonder if someone will apply this series patchs but the wait.:-) > > In fact, I'm no sure that the Acked is really meaning.:- > > Yes, by acking the patch I say I am ok with it and I agree it can go > through another tree. although I guess the two clocksource changes could very well just go through your tree. dsb() -> dsb(sy) is supposed to be equal and the second one is just cosmetics. The Kconfig and dts changes need to wait in any case for 4.5 ... but I guess that may be true for the clocksource changes as well? Heiko