From: "Paul Eggleton" <bluelightning@bluelightning.org>
To: Diego Sueiro <diego.sueiro@arm.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH 1/2] bitbake: layerindex: Fix bitbake-layers layerindex-show-depends command
Date: Wed, 21 Apr 2021 10:31:33 +1200 [thread overview]
Message-ID: <2160210.tdWV9SEqCh@linc> (raw)
In-Reply-To: <e810a80d2aa60cbfbca64abd52101a8c856c80c5.1618588951.git.diego.sueiro@arm.com>
Hi Diego
On Saturday, 17 April 2021 04:07:10 NZST Diego Sueiro wrote:
> Running 'bitbake-layers layerindex-show-depends meta-filesystems' fails
> with: ```
> Traceback (most recent call last):
> File "<...>/poky/bitbake/bin/bitbake-layers", line 93, in <module>
> ret = main()
> File "<...>/poky/bitbake/bin/bitbake-layers", line 86, in main
> return args.func(args)
> File "<...>/poky/bitbake/lib/bblayers/layerindex.py", line 209, in
> do_layerindex_show_depends self.do_layerindex_fetch(args)
> File "<...>/poky/bitbake/lib/bblayers/layerindex.py", line 182, in
> do_layerindex_fetch args.shallow)
> AttributeError: 'Namespace' object has no attribute 'shallow'
> ```
>
> Initialize the shallow attribute to fix it.
>
> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> ---
> bitbake/lib/bblayers/layerindex.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/bitbake/lib/bblayers/layerindex.py
> b/bitbake/lib/bblayers/layerindex.py index b2f27b21ee..17dfc9874d 100644
> --- a/bitbake/lib/bblayers/layerindex.py
> +++ b/bitbake/lib/bblayers/layerindex.py
> @@ -206,6 +206,7 @@ class LayerIndexPlugin(ActionPlugin):
> """
> args.show_only = True
> args.ignore = []
> + args.shallow = True
Hmm, yes. We could probably use a test that ensures this doesn't regress
again. Is that something you would be able to look at?
Thanks
Paul
next prev parent reply other threads:[~2021-04-20 22:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 16:07 [PATCH 1/2] bitbake: layerindex: Fix bitbake-layers layerindex-show-depends command Diego Sueiro
2021-04-16 16:07 ` [PATCH 2/2] bitbake: layerindex: Add --fetchdir parameter to layerindex-fetch Diego Sueiro
2021-04-20 22:30 ` [bitbake-devel] " Paul Eggleton
2021-04-21 7:33 ` Diego Sueiro
2021-04-20 22:31 ` Paul Eggleton [this message]
2021-04-21 7:33 ` [bitbake-devel] [PATCH 1/2] bitbake: layerindex: Fix bitbake-layers layerindex-show-depends command Diego Sueiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2160210.tdWV9SEqCh@linc \
--to=bluelightning@bluelightning.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=diego.sueiro@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.