From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
daniel.vetter@ffwll.ch, nariman@opensource.wolfsonmicro.com,
dri-devel@lists.freedesktop.org, wsa@sang-engineering.com
Subject: Re: [adv7511] Adding audio to transmitter driver
Date: Tue, 16 Feb 2016 01:21 +0200 [thread overview]
Message-ID: <2163343.o4fIUnaXsp@avalon> (raw)
In-Reply-To: <20160215191311.GA24093@synopsys.com>
Hi Jose,
(CC'ing Morimoto-san)
On Monday 15 February 2016 19:13:11 Jose Abreu wrote:
> Hi all,
>
> I am an employee at Synopsys and as part of our IP Prototyping Kits we are
> adding audio support to the ADV7511 HDMI transmitter. Our work is based on
> the Analog Devices kernel tree available at:
> https://github.com/analogdevicesinc/linux/blob/xcomm_zynq/drivers/gpu/drm/i
> 2c/adv7511_audio.c.
>
> Currently we are facing an difficulty regarding the organization of the
> driver. Analog Devices compiles both audio and video in a single global
> driver but we were wondering if its better to separate audio from video and
> make them as separate Kconfig entries.
>
> As we expect to introduce this in the mainline we are asking you for
> suggestions or comments about this matter. Is it any driver in the mainline
> that faces the same situation so we can base our work? What do you think
> its the best solution? Enable audio and video at the same time or make them
> separate entries?
As the ADV7511 is an I2C chip and will bind to a single driver, splitting
audio and video in two really independent drivers would be quite cumbersome.
It could be done by creating a third driver that instantiates two platform
devices, one for audio and the other one for video, exporting an API for thos
two drivers to arbitrate access to shared resources (mostly registers). That
could be done, but seems a bit overkill to me.
I would keep audio and video in a single driver, but make audio support
optional through a Kconfig option. Video support could also be made optional
in a similar fashion, is it possible to transfer audio over HDMI without a
video stream ?
An interesting issue that also needs to be addressed is how to design DT
bindings for the ADV7511 node.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-02-15 23:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 19:13 [adv7511] Adding audio to transmitter driver Jose Abreu
2016-02-15 23:21 ` Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-16 10:45 Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2163343.o4fIUnaXsp@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=Jose.Abreu@synopsys.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=nariman@opensource.wolfsonmicro.com \
--cc=wsa@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.