From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FRV: Implement the GDB remote protocol 'p' command to retrieve a register
Date: Wed, 09 Jun 2010 19:50:46 +0100 [thread overview]
Message-ID: <21653.1276109446@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1006090945531.4506@i5.linux-foundation.org>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > Implement the GDB remote protocol 'p' command to retrieve a single register
> > value.
>
> Is there any value to this? Apparently it used to work just because that
> command never did anything (rather than return an error). Why not just
> reinstate that behavior instead?
That's a reasonable argument. The 'p' command would be more efficient if gdb
uses it when required to get single values, but once it has decided to use the
'g' command, it seems to stick with it.
> There's doesn't seem to be any reason to implement the single-register
> case unless there is some legacy use of it. There's a good reason gdb
> tends to use the "register block" thing, and it tends to be easier to
> implement too (no crazy case statements etc).
It's slower to use 'g', however, if we only want the value in one register,
and I'm usually doing gdb protocol over serial.
However, as stated above, once it's decided to use 'g', gdb doesn't seem to
want to use 'p' any more.
David
prev parent reply other threads:[~2010-06-09 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 16:19 [PATCH] FRV: Implement the GDB remote protocol 'p' command to retrieve a register David Howells
2010-06-09 16:48 ` Linus Torvalds
2010-06-09 18:23 ` Frank Ch. Eigler
2010-06-09 18:29 ` Linus Torvalds
2010-06-28 4:05 ` Jason Wessel
2010-06-09 18:50 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21653.1276109446@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.