From: Thomas Monjalon <thomas@monjalon.net>
To: Tomasz Duszynski <tdu@semihalf.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 1/2] examples/kni: check if pci_dev isn't NULL before using it
Date: Wed, 25 Oct 2017 00:05:19 +0200 [thread overview]
Message-ID: <2165906.4gmW2yU9sD@xps> (raw)
In-Reply-To: <fff0add4-bf1b-50d8-dafc-e6530507cbdc@intel.com>
21/10/2017 02:26, Ferruh Yigit:
> On 10/16/2017 4:45 AM, Tomasz Duszynski wrote:
> > Since virtual devices, i.e mrvl net pmd, do not touch pci_dev
> > dereferencing it will cause segmentation fault as by default
> > it's set to NULL in rte_eth_dev_info_get().
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Fixed title: examples/kni: check PCI info not NULL before reading
Applied, thanks
The patch 2/2 is left alone as it may be unneeded.
next prev parent reply other threads:[~2017-10-24 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 11:45 [PATCH 0/2] examples/kni: update kni example application Tomasz Duszynski
2017-10-16 11:45 ` [PATCH 1/2] examples/kni: check if pci_dev isn't NULL before using it Tomasz Duszynski
2017-10-21 0:26 ` Ferruh Yigit
2017-10-24 22:05 ` Thomas Monjalon [this message]
2017-10-16 11:45 ` [PATCH 2/2] examples/kni: stop lcores while doing kni ops Tomasz Duszynski
2017-10-21 0:42 ` Ferruh Yigit
2017-10-25 9:28 ` Tomasz Duszynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2165906.4gmW2yU9sD@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=tdu@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.