From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13EF3C54EBC for ; Wed, 11 Jan 2023 11:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mA8KEbu5yKIMWiHmdVN5omV6k1GRrSwLKs/LEN4I3XQ=; b=K/fStXkXwybk2SlnwQtt8lBNcN u9X7SHhS/9lO2vFGITO2VUC1Z81Y0Sg4Blx1P5zYE0DDA9G1/uAnktcESRWQq6VXrF9F2wwGx3Hf8 bH/2V7y6DDGzitS/nki3M6WKXlraQk1KsuL4T+ipfAo77q7B0fOrmn6JaGVIQY8jqEi47iMSiqG9r 0A75jInzdC8Ri2CViXYIhzmzH3eUylYRqDaAkqJ1/5X5K83poZswlZaUxhN5cBwJYZmPXpDy8Bly6 0vm/Olcdk4qP+Yv/ZjZouUuhoZZLZ+xWNW2O09bNSU/jxwLc/WjCKu/TiJdH3RVjH5bPwPcRcxv1s rejgCbCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFZS5-00B67M-4u; Wed, 11 Jan 2023 11:39:29 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFZRx-00B63V-Et for linux-arm-kernel@lists.infradead.org; Wed, 11 Jan 2023 11:39:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1063B61C04; Wed, 11 Jan 2023 11:39:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FB5EC433EF; Wed, 11 Jan 2023 11:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673437159; bh=fo9Qg5i5zJ2ROT8P7R3Q3bCXwhSIdxzGySVAKM8a5/g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C1OtgBbfa4iGPLTALKhnlhxpUu0xDibBGnt63TPVDD60oI9Rwny6cH4S3WsOi8PdL YSGSd0BjvYCsXl1BahI60hz4Ai1NOAtvoOHlnGWNjfiyH1dOfd4oUirOI9GfHEIC0Q uYaM2CEMdcPAf+C3Ee20LykXfc/nfI0OFbmDhlm+fOagBJHTyjTbX0+bMT8tmPcaFF gOSItmmBl6DIQy9kTpuEmiehDyeIg55JBBqerm3+cV2+8XjSifB/q1b5js298A8jwc DiuCSeNs/KhQ7BawmdMTKs54ybJq1W3Sxvta2Bej9dJi915ZRgc7xeIJugrdXex+d1 3uBeMHGd6mVeg== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pFZRs-000r0M-M6; Wed, 11 Jan 2023 11:39:17 +0000 MIME-Version: 1.0 Date: Wed, 11 Jan 2023 11:39:16 +0000 From: Marc Zyngier To: Ganapatrao Kulkarni Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, scott@os.amperecomputing.com, Darren Hart Subject: Re: [PATCH 0/3] KVM: arm64: nv: Fixes for Nested Virtualization issues In-Reply-To: <4d952300-0681-41ff-b416-38fbae4ebea6@os.amperecomputing.com> References: <20220824060304.21128-1-gankulkarni@os.amperecomputing.com> <6171dc7c-5d83-d378-db9e-d94f27afe43a@os.amperecomputing.com> <87o7r6dpi8.wl-maz@kernel.org> <4d952300-0681-41ff-b416-38fbae4ebea6@os.amperecomputing.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <2169cc83d3015727f5f486844c8c4647@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: gankulkarni@os.amperecomputing.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, scott@os.amperecomputing.com, darren@os.amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_033921_615376_8754B590 X-CRM114-Status: GOOD ( 24.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMy0wMS0xMSAwODo0NiwgR2FuYXBhdHJhbyBLdWxrYXJuaSB3cm90ZToKPiBPbiAxMS0w MS0yMDIzIDAzOjI0IGFtLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+IE9uIFR1ZSwgMTAgSmFuIDIw MjMgMTI6MTc6MjAgKzAwMDAsCj4+IEdhbmFwYXRyYW8gS3Vsa2FybmkgPGdhbmt1bGthcm5pQG9z LmFtcGVyZWNvbXB1dGluZy5jb20+IHdyb3RlOgo+Pj4gCj4+PiBJIGFtIGN1cnJlbnRseSB3b3Jr aW5nIGFyb3VuZCB0aGlzIHdpdGggIm5vaGx0IiBrZXJuZWwgcGFyYW0gdG8KPj4+IE5lc3RlZFZN LiBBbnkgc3VnZ2VzdGlvbnMgdG8gaGFuZGxlL2ZpeCB0aGlzIGNhc2UvaXNzdWUgYW5kIGF2b2lk IHRoZQo+Pj4gc2xvd25lc3Mgb2YgYm9vdGluZyBvZiBOZXN0ZWRWTSB3aXRoIG1vcmUgY29yZXM/ Cj4+PiAKPj4+IE5vdGU6IEd1ZXN0LUh5cGVydmlzb3IgYW5kIE5lc3RlZFZNIGFyZSB1c2luZyBk ZWZhdWx0IGtlcm5lbCAKPj4+IGluc3RhbGxlZAo+Pj4gdXNpbmcgRmVkb3JhIDM2IGlzby4KPj4g Cj4+IERlc3BpdGUgd2hhdCBJIHNhaWQgZWFybGllciwgSSBoYXZlIGEgdmFndWUgaWRlYSBoZXJl LCB0aGFua3MgdG8gdGhlCj4+IGludGVyZXN0aW5nIGNhbGwgdHJhY2VzIHRoYXQgeW91IHByb3Zp ZGVkICh0aGlzIGlzIHJlYWxseSBhd2Vzb21lIHdvcmsKPj4gQlRXLCBnaXZlbiBob3cgaGFyZCBp dCBpcyB0byB0cmFjZSB0aGluZ3MgYWNyb3NzIDMgZGlmZmVyZW50IGtlcm5lbHMpLgo+PiAKPj4g V2UgY2FuIHNsaWdodGx5IGxpbWl0IHRoZSBpbXBhY3Qgb2YgdGhlIHByZXBhcmUvZmluaXNoIHNl cXVlbmNlIGlmIHRoZQo+PiBndWVzdCBoeXBlcnZpc29yIG9ubHkgYWNjZXNzZXMgdGhlIGFjdGl2 ZSByZWdpc3RlcnMgZm9yIFNHSXMvUFBJcyBvbgo+PiB0aGUgdmNwdSB0aGF0IG93bnMgdGhlbSwg Zm9yYmlkZGluZyBhbnkgY3Jvc3MtQ1BVLXRvLXJlZGlzdHJpYnV0b3IKPj4gYWNjZXNzLgo+PiAK Pj4gU29tZXRoaW5nIGFsb25nIHRoZXNlIGxpbmVzLCB3aGljaCBpcyBvbmx5IGJvb3QtdGVzdGVk LiBMZXQgbWUga25vdwo+PiBob3cgdGhpcyBmYXJlcyBmb3IgeW91Lgo+PiAKPj4gVGhhbmtzLAo+ PiAKPj4gCU0uCj4+IAo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vdmdpYy92Z2ljLW1t aW8uYyAKPj4gYi9hcmNoL2FybTY0L2t2bS92Z2ljL3ZnaWMtbW1pby5jCj4+IGluZGV4IGIzMmQ0 MzRjMWQ0YS4uMWNjYTQ1YmU1MzM1IDEwMDY0NAo+PiAtLS0gYS9hcmNoL2FybTY0L2t2bS92Z2lj L3ZnaWMtbW1pby5jCj4+ICsrKyBiL2FyY2gvYXJtNjQva3ZtL3ZnaWMvdmdpYy1tbWlvLmMKPj4g QEAgLTQ3Myw5ICs0NzMsMTAgQEAgaW50IHZnaWNfdWFjY2Vzc193cml0ZV9jcGVuZGluZyhzdHJ1 Y3Qga3ZtX3ZjcHUgCj4+ICp2Y3B1LAo+PiAgICAqIGFjdGl2ZSBzdGF0ZSBjYW4gYmUgb3Zlcndy aXR0ZW4gd2hlbiB0aGUgVkNQVSdzIHN0YXRlIGlzIHN5bmNlZCAKPj4gY29taW5nIGJhY2sKPj4g ICAgKiBmcm9tIHRoZSBndWVzdC4KPj4gICAgKgo+PiAtICogRm9yIHNoYXJlZCBpbnRlcnJ1cHRz IGFzIHdlbGwgYXMgR0lDdjMgcHJpdmF0ZSBpbnRlcnJ1cHRzLCB3ZSBoYXZlIAo+PiB0bwo+PiAt ICogc3RvcCBhbGwgdGhlIFZDUFVzIGJlY2F1c2UgaW50ZXJydXB0cyBjYW4gYmUgbWlncmF0ZWQg d2hpbGUgd2UgCj4+IGRvbid0IGhvbGQKPj4gLSAqIHRoZSBJUlEgbG9ja3MgYW5kIHdlIGRvbid0 IHdhbnQgdG8gYmUgY2hhc2luZyBtb3ZpbmcgdGFyZ2V0cy4KPj4gKyAqIEZvciBzaGFyZWQgaW50 ZXJydXB0cyBhcyB3ZWxsIGFzIEdJQ3YzIHByaXZhdGUgaW50ZXJydXB0cyBhY2Nlc3NlZCAKPj4g ZnJvbSB0aGUKPj4gKyAqIG5vbi1vd25pbmcgQ1BVLCB3ZSBoYXZlIHRvIHN0b3AgYWxsIHRoZSBW Q1BVcyBiZWNhdXNlIGludGVycnVwdHMgCj4+IGNhbiBiZQo+PiArICogbWlncmF0ZWQgd2hpbGUg d2UgZG9uJ3QgaG9sZCB0aGUgSVJRIGxvY2tzIGFuZCB3ZSBkb24ndCB3YW50IHRvIGJlIAo+PiBj aGFzaW5nCj4+ICsgKiBtb3ZpbmcgdGFyZ2V0cy4KPj4gICAgKgo+PiAgICAqIEZvciBHSUN2MiBw cml2YXRlIGludGVycnVwdHMgd2UgZG9uJ3QgaGF2ZSB0byBkbyBhbnl0aGluZyBiZWNhdXNlCj4+ ICAgICogdXNlcnNwYWNlIGFjY2Vzc2VzIHRvIHRoZSBWR0lDIHN0YXRlIGFscmVhZHkgcmVxdWly ZSBhbGwgVkNQVXMgdG8gCj4+IGJlCj4+IEBAIC00ODQsNyArNDg1LDggQEAgaW50IHZnaWNfdWFj Y2Vzc193cml0ZV9jcGVuZGluZyhzdHJ1Y3Qga3ZtX3ZjcHUgCj4+ICp2Y3B1LAo+PiAgICAqLwo+ PiAgIHN0YXRpYyB2b2lkIHZnaWNfYWNjZXNzX2FjdGl2ZV9wcmVwYXJlKHN0cnVjdCBrdm1fdmNw dSAqdmNwdSwgdTMyIAo+PiBpbnRpZCkKPj4gICB7Cj4+IC0JaWYgKHZjcHUtPmt2bS0+YXJjaC52 Z2ljLnZnaWNfbW9kZWwgPT0gS1ZNX0RFVl9UWVBFX0FSTV9WR0lDX1YzIHx8Cj4+ICsJaWYgKCh2 Y3B1LT5rdm0tPmFyY2gudmdpYy52Z2ljX21vZGVsID09IEtWTV9ERVZfVFlQRV9BUk1fVkdJQ19W MyAmJgo+PiArCSAgICAgdmNwdSA9PSBrdm1fZ2V0X3J1bm5pbmdfdmNwdSgpKSB8fAo+IAo+IFRo YW5rcyBNYXJjIGZvciB0aGUgcGF0Y2ghCj4gCj4gSSB0aGluaywgeW91IG1lYW4gbm90IGVxdWFs IHRvPwo+ICsgICAgICAgICAgIHZjcHUgIT0ga3ZtX2dldF9ydW5uaW5nX3ZjcHUoKSkgfHwKClll YWgsIGV4YWN0bHkuIEkgd29rZSB1cCB0aGlzIG1vcm5pbmcgcmVhbGlzaW5nIHRoaXMgcGF0Y2gg d2FzCiphbG1vc3QqIHJpZ2h0LiBEb24ndCB3cml0ZSBwYXRjaGVzIGxpa2UgdGhpcyBhZnRlciBh IGxvbmcgZGF5CmF0IHdvcmsuLi4KCj4gV2l0aCB0aGUgY2hhbmdlIHRvIG5vdC1lcXVhbCwgdGhl IGlzc3VlIGlzIGZpeGVkIGFuZCBJIGNvdWxkIHNlZSB0aGUKPiBOZXN0ZWRWTSBib290aW5nIGlz IHByZXR0eSBmYXN0IHdpdGggaGlnaGVyIG51bWJlciBvZiBjb3JlcyBhcyB3ZWxsLgoKR29vZCwg dGhhbmtzIGZvciB0ZXN0aW5nIGl0LiBJJ2xsIHJvbGwgdXAgYW4gYWN0dWFsIHBhdGNoIGZvciB0 aGF0CmFuZCBzdGljayBpdCBpbiB0aGUgbW9uc3RlciBxdWV1ZS4KCkNoZWVycywKCiAgwqAgICAg IE0uCi0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0IHNtZWxscyBmdW5ueS4uLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB46C46467 for ; Wed, 11 Jan 2023 11:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231603AbjAKLkn (ORCPT ); Wed, 11 Jan 2023 06:40:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238209AbjAKLkD (ORCPT ); Wed, 11 Jan 2023 06:40:03 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12D972AFD for ; Wed, 11 Jan 2023 03:39:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C2C36B81AD3 for ; Wed, 11 Jan 2023 11:39:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FB5EC433EF; Wed, 11 Jan 2023 11:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673437159; bh=fo9Qg5i5zJ2ROT8P7R3Q3bCXwhSIdxzGySVAKM8a5/g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C1OtgBbfa4iGPLTALKhnlhxpUu0xDibBGnt63TPVDD60oI9Rwny6cH4S3WsOi8PdL YSGSd0BjvYCsXl1BahI60hz4Ai1NOAtvoOHlnGWNjfiyH1dOfd4oUirOI9GfHEIC0Q uYaM2CEMdcPAf+C3Ee20LykXfc/nfI0OFbmDhlm+fOagBJHTyjTbX0+bMT8tmPcaFF gOSItmmBl6DIQy9kTpuEmiehDyeIg55JBBqerm3+cV2+8XjSifB/q1b5js298A8jwc DiuCSeNs/KhQ7BawmdMTKs54ybJq1W3Sxvta2Bej9dJi915ZRgc7xeIJugrdXex+d1 3uBeMHGd6mVeg== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pFZRs-000r0M-M6; Wed, 11 Jan 2023 11:39:17 +0000 MIME-Version: 1.0 Date: Wed, 11 Jan 2023 11:39:16 +0000 From: Marc Zyngier To: Ganapatrao Kulkarni Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, scott@os.amperecomputing.com, Darren Hart Subject: Re: [PATCH 0/3] KVM: arm64: nv: Fixes for Nested Virtualization issues In-Reply-To: <4d952300-0681-41ff-b416-38fbae4ebea6@os.amperecomputing.com> References: <20220824060304.21128-1-gankulkarni@os.amperecomputing.com> <6171dc7c-5d83-d378-db9e-d94f27afe43a@os.amperecomputing.com> <87o7r6dpi8.wl-maz@kernel.org> <4d952300-0681-41ff-b416-38fbae4ebea6@os.amperecomputing.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <2169cc83d3015727f5f486844c8c4647@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: gankulkarni@os.amperecomputing.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, scott@os.amperecomputing.com, darren@os.amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2023-01-11 08:46, Ganapatrao Kulkarni wrote: > On 11-01-2023 03:24 am, Marc Zyngier wrote: >> On Tue, 10 Jan 2023 12:17:20 +0000, >> Ganapatrao Kulkarni wrote: >>> >>> I am currently working around this with "nohlt" kernel param to >>> NestedVM. Any suggestions to handle/fix this case/issue and avoid the >>> slowness of booting of NestedVM with more cores? >>> >>> Note: Guest-Hypervisor and NestedVM are using default kernel >>> installed >>> using Fedora 36 iso. >> >> Despite what I said earlier, I have a vague idea here, thanks to the >> interesting call traces that you provided (this is really awesome work >> BTW, given how hard it is to trace things across 3 different kernels). >> >> We can slightly limit the impact of the prepare/finish sequence if the >> guest hypervisor only accesses the active registers for SGIs/PPIs on >> the vcpu that owns them, forbidding any cross-CPU-to-redistributor >> access. >> >> Something along these lines, which is only boot-tested. Let me know >> how this fares for you. >> >> Thanks, >> >> M. >> >> diff --git a/arch/arm64/kvm/vgic/vgic-mmio.c >> b/arch/arm64/kvm/vgic/vgic-mmio.c >> index b32d434c1d4a..1cca45be5335 100644 >> --- a/arch/arm64/kvm/vgic/vgic-mmio.c >> +++ b/arch/arm64/kvm/vgic/vgic-mmio.c >> @@ -473,9 +473,10 @@ int vgic_uaccess_write_cpending(struct kvm_vcpu >> *vcpu, >> * active state can be overwritten when the VCPU's state is synced >> coming back >> * from the guest. >> * >> - * For shared interrupts as well as GICv3 private interrupts, we have >> to >> - * stop all the VCPUs because interrupts can be migrated while we >> don't hold >> - * the IRQ locks and we don't want to be chasing moving targets. >> + * For shared interrupts as well as GICv3 private interrupts accessed >> from the >> + * non-owning CPU, we have to stop all the VCPUs because interrupts >> can be >> + * migrated while we don't hold the IRQ locks and we don't want to be >> chasing >> + * moving targets. >> * >> * For GICv2 private interrupts we don't have to do anything because >> * userspace accesses to the VGIC state already require all VCPUs to >> be >> @@ -484,7 +485,8 @@ int vgic_uaccess_write_cpending(struct kvm_vcpu >> *vcpu, >> */ >> static void vgic_access_active_prepare(struct kvm_vcpu *vcpu, u32 >> intid) >> { >> - if (vcpu->kvm->arch.vgic.vgic_model == KVM_DEV_TYPE_ARM_VGIC_V3 || >> + if ((vcpu->kvm->arch.vgic.vgic_model == KVM_DEV_TYPE_ARM_VGIC_V3 && >> + vcpu == kvm_get_running_vcpu()) || > > Thanks Marc for the patch! > > I think, you mean not equal to? > + vcpu != kvm_get_running_vcpu()) || Yeah, exactly. I woke up this morning realising this patch was *almost* right. Don't write patches like this after a long day at work... > With the change to not-equal, the issue is fixed and I could see the > NestedVM booting is pretty fast with higher number of cores as well. Good, thanks for testing it. I'll roll up an actual patch for that and stick it in the monster queue. Cheers,   M. -- Jazz is not dead. It just smells funny...