All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Sven Eckelmann <sven@narfation.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] alfred: Update version when adding data to dataset
Date: Wed, 11 Mar 2015 13:08:22 +0100	[thread overview]
Message-ID: <2170540.kuiCrXiOC1@prime> (raw)
In-Reply-To: <1425768078-15380-1-git-send-email-sven@narfation.org>

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

On Saturday 07 March 2015 23:41:17 Sven Eckelmann wrote:
> The dataset stores the source and the alfred_tlv of the send data next to
> the actual data buffer. The source and alfred_tlv::type was used to find an
> entry in the dataset hashtable when reading/updating the buffer. The
> alfred_tlv::length is always updated when the size of the associated buffer
> gets modified.
> 
> But the alfred_tlv::version is only written when receiving the first data
> for a dataset. But this initial (maybe outdated) version is always
> propagated when a client asks over the unix socket or the dataset is
> exchanged between alfred servers. This has to also be updated when new data
> is added to the dataset to avoid clients to interpret the data using the
> wrong data format version.
> 

Applied in revision 17d1102.

Thanks!
    Simon

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      parent reply	other threads:[~2015-03-11 12:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07 22:41 [B.A.T.M.A.N.] [PATCH 1/2] alfred: Update version when adding data to dataset Sven Eckelmann
2015-03-07 22:41 ` [B.A.T.M.A.N.] [PATCH 2/2] alfred: Add option to the client to print extra data information Sven Eckelmann
2015-03-07 22:45 ` [B.A.T.M.A.N.] [PATCHv2 " Sven Eckelmann
2015-03-11 12:08   ` Simon Wunderlich
2015-03-11 12:08 ` Simon Wunderlich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2170540.kuiCrXiOC1@prime \
    --to=sw@simonwunderlich.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.