From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C540323393E for ; Wed, 10 Jun 2026 06:00:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781071241; cv=none; b=uDZcOviiAJIxnio//Q2gMzJG1ECANYBerZzZ7vUWCq+m6GsHxwIz/JoVzksGiYC5oShNwg70r6fAaMGWi0ouGbEZ70e+f1eorDe1kFB7g3bG+VKfhmyMuYQwqRAuIwR4p+DDwOLzNB7l+WbbRRJ0EyrmBoYMWih426GEOFY2/tA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781071241; c=relaxed/simple; bh=S8CEMNCK3qGJNfDkKioIBoHNvaLuSk/NwLxdKcqC1Ls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KdtE6FvtIHqRH2e3R6dcsnBo/PeuoPAVsimWOk+LwUdrXBgoa8EkNIBbBl1B7qSbZhFcgSsRPxlYzgDXosEexX7rdQmFwmp7mhxnIN+GEHX0OkVqciq6+p62ToLELSW696PDDOOdEtUEbjDdxm99LBfxiLtyJzEmEpXyKt1bFMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=IFriv+0s; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="IFriv+0s" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-39661f81eacso68365181fa.0 for ; Tue, 09 Jun 2026 23:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781071238; x=1781676038; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gj0YYK+8W8BmuuGLUjKiEFrVEApz47d5/8fZSNVUxGs=; b=IFriv+0sKu3CxcCpyIJeXMfi36nmgEs0snJknx+EVTPAcR8bQxlvkNzD2VaJrZzVZO Ns4c8SuTsRY8AC0isfE5bdCaCtM28ZpwmeQK0aKSgru3SpuEnelaujhXJmj7fjcE8Fpi Y4j4WKJdtSQCW2C6ChcSlejYChNYyVHLGDoxQqX6OE6QIuwZF0SMvrVKN1n3QyF0LVKF kCIWYVOZSTcNtQw51/qqy0kmrazJCy9mI02oXD/rfKPRCCSnvmORMg1jgjdBSsM6HKa4 jbacnjO5GLLAvf9RMsh9ZVxHalT60ovmd7ENu5FUAXwqi5evLY3zQi80fLaPS4MNg5Nd PKGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781071238; x=1781676038; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gj0YYK+8W8BmuuGLUjKiEFrVEApz47d5/8fZSNVUxGs=; b=J7AjqNaZ11u40lNLbbDd2UzfwtcNBRxx7vYAyIsmsxu95iYa4hAQgA1Rq8+XOcLZHu LAGDnm+zEja8VlFspyr8YiwKoS2+5TJhJAVuHlCKPTc5MOK5tLrtjbzrI6lIobH5xkQK 17d/CrfqMFCWJ3SF2Uhzw/LIR580uwDqlPbf3+1GJoRhTqqj6qw3C+uW+DaMhzsfm38g cWY4jC6ctNa6XxrBUG3iY+DzvOM5C2fwFqD92RMUAYtNB2sMvAzyVtXB6lNO2GfZJAlB I06TgG9+cwb2OFkTjKaezk5RWxVdT0dZXNV2PSFGIWgOS5ayADZRZdq+m3DiiE3UdyFP PcVQ== X-Forwarded-Encrypted: i=1; AFNElJ8PPaBv1VSQVF/q0BCLg7XDkjhtqhNlzMZFquM8zvkALZVxnCporBs14JKwbKEsHIf2++wGStbFGLWsQg==@vger.kernel.org X-Gm-Message-State: AOJu0Yx5dh72BGzqFSa7kqEBFmlJ2hN7kX1s3lrPTmHPAWFsP7nfrlSy JGpSZ6Ew68tbvyuKZ6OXcsh5JSmPZJne1NfXELFJbfg9a17e9R9jfaukHyR0vPqjKb8= X-Gm-Gg: Acq92OF+P/6NYrw9pDnmIYXodjRi+1WMJ2kdtcLgfOH6D2DySpiDrzQAqYx8Hhmah04 XHdjNi7n5oqIt0MlqNJ4Wff5ryZShkof5tTmqpSqIPd87C1CvsnWiWVetnyl61noZ0Yf/VHL/3K qagG8kRmgoW2kbImVaY4/xeSTBf5XoNzPgREhUmtN/qmtxvqtVFFYQak2f0l+L6SsKI9mV5O165 tmasKfUgxYyspbsbvnvjWhUVihgCAhb681738heuMUqweGgVFfafW/Cw1k2b5QiogpTbKQ0lXOA APLh+UqeWeXoqF9XFimDl8MehiUjlpUniYf91N1oJXaCt8iP0yv4RlkDH9srCeGNDMXglMhjZrS KJrtc72dDepZtEtBXMMSB24KMZ9nFJOx7Wz4KkCgU0kisvYhrE+qzNKkvMvoN5ECDO76/9wx5Lf keLzOSIC23JRbYCTdDDMAx5Kn/NbVE0p0jFZTqSQnRqQeEtqv8mIfQrwX9VV6BGQG6RJFvWzU= X-Received: by 2002:a2e:b8cd:0:b0:396:a647:76f5 with SMTP id 38308e7fff4ca-396d285f55dmr58137321fa.5.1781071237888; Tue, 09 Jun 2026 23:00:37 -0700 (PDT) Received: from ?IPV6:2001:a62:1439:d001:a0af:1164:c6fd:8c51? ([2001:a62:1439:d001:a0af:1164:c6fd:8c51]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-396abd6cbe6sm59530741fa.0.2026.06.09.23.00.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 23:00:36 -0700 (PDT) Message-ID: <21746ee7-cff3-4db8-959d-dd693389492d@suse.com> Date: Wed, 10 Jun 2026 08:00:30 +0200 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] scsi: scan: allocate sdev and starget on the NUMA node of the host adapter To: Sumit Saxena , "Martin K . Petersen" , Jens Axboe Cc: "James E . J . Bottomley" , linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, Adam Radford , Khalid Aziz , Adaptec OEM Raid Solutions , Matthew Wilcox , "Juergen E . Fischer" , Russell King , linux-arm-kernel@lists.infradead.org, Finn Thain , Michael Schmitz , Anil Gurumurthy , Sudarsana Kalluru , Oliver Neukum , Ali Akcaagac , Jamie Lenehan , Ram Vegesna , target-devel@vger.kernel.org, Bradley Grove , Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , Yihang Li , Don Brace , storagedev@microchip.com, HighPoint Linux Team , Tyrel Datwyler , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, Brian King , Lee Duncan , Chris Leech , Mike Christie , open-iscsi@googlegroups.com, Justin Tee , Paul Ely , Kashyap Desai , Shivasharan S , Chandrakanth Patil , megaraidlinux.pdl@broadcom.com, Sathya Prakash Veerichetty , Sreekanth Reddy , mpi3mr-linuxdrv.pdl@broadcom.com, Suganath Prabu Subramani , Ranjan Kumar , MPT-FusionLinux.pdl@broadcom.com, Daniel Palmer , GOTO Masanori , YOKOTA Hiroshi , Jack Wang , Geoff Levand , Michael Reed , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Narsimhulu Musini , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , linux-hyperv@vger.kernel.org, "Michael S . Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio Perez , virtualization@lists.linux.dev, Vishal Bhakta , bcm-kernel-feedback-list@broadcom.com, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, James Rizzo References: <20260609121806.2121755-1-sumit.saxena@broadcom.com> <20260609121806.2121755-2-sumit.saxena@broadcom.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260609121806.2121755-2-sumit.saxena@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/9/26 14:18, Sumit Saxena wrote: > From: James Rizzo > > When a host adapter is attached to a specific NUMA node, allocating > scsi_device and scsi_target via kzalloc() may place them on a remote > node. All hot-path I/O accesses to these structures then cross the NUMA > interconnect, adding latency and consuming inter-node bandwidth. > > Use kzalloc_node() with dev_to_node(shost->dma_dev) so allocations land > on the same node as the HBA, reducing cross-node traffic and improving > I/O performance on NUMA systems. > > Signed-off-by: James Rizzo > Signed-off-by: Sumit Saxena > --- > drivers/scsi/scsi_scan.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.com +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich