From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Morris Pan <morris.pan@mediatek.com>,
airlied@redhat.com, kraxel@redhat.com
Cc: srv_heupstream@mediatek.com, gurchetansingh@chromium.org,
olvaffe@gmail.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, simona@ffwll.ch,
dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev
Subject: Re: [PATCH] drm/virtgpu: Add PM support for suspend/resume
Date: Wed, 8 Apr 2026 15:59:05 +0300 [thread overview]
Message-ID: <2175a05a-d83f-4252-bbf8-581ae652a6b8@collabora.com> (raw)
In-Reply-To: <20260401061050.1035881-1-morris.pan@mediatek.com>
Hi,
On 4/1/26 09:10, Morris Pan wrote:
> diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c
> index a5ce96fb8a1d..fbca0a82958c 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_drv.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c
> @@ -145,6 +145,40 @@ static void virtio_gpu_config_changed(struct virtio_device *vdev)
> schedule_work(&vgdev->config_changed_work);
> }
>
> +#ifdef CONFIG_PM_SLEEP
> +static int virtgpu_freeze(struct virtio_device *vdev)
> +{
> + vdev->config->del_vqs(vdev);
> + virtio_reset_device(vdev);
> +
> + return 0;
> +}
VirtIO-GPU shouldn't be reset freely. See [1] and follow previous
hibernation-support discussions on the ML.
[1[
https://lore.kernel.org/dri-devel/20260107182745.229481-1-dongwon.kim@intel.com/
--
Best regards,
Dmitry
next prev parent reply other threads:[~2026-04-08 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 6:10 [PATCH] drm/virtgpu: Add PM support for suspend/resume Morris Pan
2026-04-01 6:24 ` Thomas Zimmermann
2026-04-08 7:04 ` Morris Pan (潘泰為)
2026-04-08 12:59 ` Dmitry Osipenko [this message]
2026-04-17 9:40 ` Morris Pan (潘泰為)
2026-04-30 22:49 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2175a05a-d83f-4252-bbf8-581ae652a6b8@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=kraxel@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=morris.pan@mediatek.com \
--cc=mripard@kernel.org \
--cc=olvaffe@gmail.com \
--cc=simona@ffwll.ch \
--cc=srv_heupstream@mediatek.com \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.