From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] event/sw: fix events mis-identified as needing reorder Date: Thu, 20 Apr 2017 00:31:16 +0200 Message-ID: <2176270.5Bc8X6HNAl@xps> References: <20170414151815.12850-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Van Haaren, Harry" To: "Richardson, Bruce" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 65F32689E for ; Thu, 20 Apr 2017 00:31:18 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2017 17:28, Van Haaren, Harry: > From: Richardson, Bruce > Sent: Friday, April 14, 2017 4:18 PM > > > > When taking events from a port, we checked the history list to check if > > the > > event needed to be put back in order i.e. originally came from a reordered > > queue type. The check for reordering involved checking if the reorder > > buffer entry pointer was null. However, after that pointer was used it was > > never cleared to null again. > > > > This caused problems when we had mixed reordered and atomic or parallel > > events, as the events from the latter two queue types were misidentified > > as > > needing reordering. This let in some cases to crashes, but mostly led to > > dropping events, and then application lock-up. > > > > Fixes: 617995dfc5b2 ("event/sw: add scheduling logic") > > > > Signed-off-by: Bruce Richardson > > +CC Thomas, would you pick this directly to master please, as no > next-eventdev will be merged, thanks. > > Acked-by: Harry van Haaren Applied, thanks